Skip to content

Commit 5b2af7c

Browse files
committed
Follow Codacy suggestions
1 parent fa4e959 commit 5b2af7c

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

src/main/java/org/keepassxc/Connection.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ public abstract class Connection implements AutoCloseable {
2020
private TweetNaclFast.Box.KeyPair keyPair;
2121
private TweetNaclFast.Box.KeyPair idKeyPair;
2222
private String clientID;
23-
private Map<String, Object> map;
2423
private byte[] nonce;
2524
private String associate_id;
2625
protected final String PROXY_NAME = "org.keepassxc.KeePassXC.BrowserServer";

src/main/java/org/purejava/KeepassProxyAccess.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ public String getIdKeyPairPublicKey() {
130130
return this.connection.getIdKeyPairPublicKey();
131131
}
132132

133-
public String getAssociate_id() {
133+
public String getAssociateId() {
134134
return this.connection.getAssociateId();
135135
}
136136
}

src/test/java/org/purejava/KeepassProxyAccessTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* This test is designed to run within CI, where a KeePassXC database is not available.
1414
*/
1515
public class KeepassProxyAccessTest {
16-
KeepassProxyAccess kpa = new KeepassProxyAccess();
16+
private KeepassProxyAccess kpa = new KeepassProxyAccess();
1717

1818
@Test
1919
@Order(1)

src/test/java/org/purejava/LockedDatabaseTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* For this test, KeePassXC should be started, but locked.
1212
*/
1313
public class LockedDatabaseTest {
14-
KeepassProxyAccess kpa = new KeepassProxyAccess();
14+
private KeepassProxyAccess kpa = new KeepassProxyAccess();
1515

1616
@Test
1717
@Order(2)

src/test/java/org/purejava/UnlockedDatabaseTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
public class UnlockedDatabaseTest {
2121
static final Logger log = LoggerFactory.getLogger(UnlockedDatabaseTest.class);
2222

23-
KeepassProxyAccess kpa = new KeepassProxyAccess();
23+
private KeepassProxyAccess kpa = new KeepassProxyAccess();
2424

2525
@Test
2626
@Order(3)
@@ -30,7 +30,7 @@ public void shouldHaveNoErrors() throws IOException, KeepassProxyAccessException
3030
kpa.connect();
3131
kpa.associate();
3232
assertTrue(null != kpa.getDatabasehash() && !kpa.getDatabasehash().isEmpty());
33-
kpa.testAssociate(kpa.getAssociate_id(), kpa.getIdKeyPairPublicKey());
33+
kpa.testAssociate(kpa.getAssociateId(), kpa.getIdKeyPairPublicKey());
3434
log.info("Please allow access to credentials");
3535
List<Map<String, String>> l = new ArrayList<>();
3636
l.add(kpa.exportConnection());

0 commit comments

Comments
 (0)