Rename bracket condition labels

Author: natefaubion

src/Control/Monad/Aff.js

@@ -507,11 +507,11 @@ function runFiber(util, suspended, aff, completeCb) {
             attempts = new Aff(CONS, new Aff(FINALIZED, step), attempts._2);
             status   = CONTINUE;
             if (interrupt !== null) {
-              step = attempt._1.kill(util.fromLeft(interrupt))(attempt._2);
+              step = attempt._1.killed(util.fromLeft(interrupt))(attempt._2);
             } else if (fail !== null) {
-              step = attempt._1.throw(util.fromLeft(fail))(attempt._2);
+              step = attempt._1.failed(util.fromLeft(fail))(attempt._2);
             } else {
-              step = attempt._1.release(attempt._2);
+              step = attempt._1.completed(attempt._2);
             }
             break;
 

src/Control/Monad/Aff.purs

@@ -246,11 +246,11 @@ atomically a = bracket a (const (pure unit)) pure
 -- | acquisition nor disposal may be cancelled and are guaranteed to run until
 -- | they complete.
 bracket ∷ ∀ eff a b. Aff eff a → (a → Aff eff Unit) → (a → Aff eff b) → Aff eff b
-bracket acquire release =
+bracket acquire completed =
   generalBracket acquire
-    { kill: const release
-    , throw: const release
-    , release
+    { killed: const completed
+    , failed: const completed
+    , completed
     }
 
 foreign import _pure ∷ ∀ eff a. a → Aff eff a
@@ -266,9 +266,9 @@ foreign import _parAffApply ∷ ∀ eff a b. ParAff eff (a → b) → ParAff eff
 foreign import _parAffAlt ∷ ∀ eff a. ParAff eff a → ParAff eff a → ParAff eff a
 
 type BracketConditions eff a =
-  { kill ∷ Error → a → Aff eff Unit
-  , throw ∷ Error → a → Aff eff Unit
-  , release ∷ a → Aff eff Unit
+  { killed ∷ Error → a → Aff eff Unit
+  , failed ∷ Error → a → Aff eff Unit
+  , completed ∷ a → Aff eff Unit
   }
 
 -- | A general purpose bracket

test/Test/Main.purs

@@ -235,9 +235,9 @@ test_general_bracket = assert "bracket/general" do
       pure s
     bracketAction s =
       generalBracket (action s)
-        { kill: \error s' → void $ action (s' <> "/kill/" <> message error)
-        , throw: \error s' → void $ action (s' <> "/throw/" <> message error)
-        , release: \s' → void $ action (s' <> "/release")
+        { killed: \error s' → void $ action (s' <> "/kill/" <> message error)
+        , failed: \error s' → void $ action (s' <> "/throw/" <> message error)
+        , completed: \s' → void $ action (s' <> "/release")
         }
 
   f1 ← forkAff $ bracketAction "foo" (const (action "a"))
@@ -322,9 +322,9 @@ test_kill_child = assert "kill/child" do
   let
     action s = generalBracket
       (modifyRef ref (_ <> "acquire" <> s))
-      { throw: \_ _ → modifyRef ref (_ <> "throw" <> s)
-      , kill: \_ _ → modifyRef ref (_ <> "kill" <> s)
-      , release: \_ → modifyRef ref (_ <> "complete" <> s)
+      { failed: \_ _ → modifyRef ref (_ <> "throw" <> s)
+      , killed: \_ _ → modifyRef ref (_ <> "kill" <> s)
+      , completed: \_ → modifyRef ref (_ <> "complete" <> s)
       }
       (\_ -> do
         delay (Milliseconds 10.0)