Add failing test for #174

Author: Felix Schlitter

src/Effect/Aff.js

@@ -357,7 +357,15 @@ var Aff = function () {
             if (bhead === null) {
               attempts = new Aff(CONS, step, attempts, interrupt);
             } else {
-              attempts = new Aff(CONS, step, new Aff(CONS, new Aff(RESUME, bhead, btail), attempts, interrupt), interrupt);
+              attempts = new Aff(CONS,
+                                 step,
+                                 new Aff(CONS,
+                                         new Aff(RESUME,
+                                                 bhead,
+                                                 btail),
+                                         attempts,
+                                         interrupt),
+                                 interrupt);
             }
             bhead    = null;
             btail    = null;
@@ -370,9 +378,21 @@ var Aff = function () {
           case BRACKET:
             bracketCount++;
             if (bhead === null) {
-              attempts = new Aff(CONS, step, attempts, interrupt);
+              attempts = new Aff(CONS,
+                                 step,
+                                 attempts,
+                                 interrupt);
             } else {
-              attempts = new Aff(CONS, step, new Aff(CONS, new Aff(RESUME, bhead, btail), attempts, interrupt), interrupt);
+              attempts =
+                new Aff(CONS,
+                        step,
+                        new Aff(CONS,
+                                new Aff(RESUME,
+                                        bhead,
+                                        btail),
+                                attempts,
+                                interrupt),
+                        interrupt);
             }
             bhead  = null;
             btail  = null;
@@ -455,7 +475,12 @@ var Aff = function () {
                 result   = util.fromRight(step);
                 // We need to enqueue the Release with the same interrupt
                 // status as the Bracket that is initiating it.
-                attempts = new Aff(CONS, new Aff(RELEASE, attempt._2, result), attempts, tmp);
+                attempts = new Aff(CONS,
+                                   new Aff(RELEASE,
+                                           attempt._2,
+                                           result),
+                                   attempts,
+                                   tmp);
                 // We should only coninue as long as the interrupt status has not changed or
                 // we are currently within a non-interruptable finalizer.
                 if (interrupt === tmp || bracketCount > 0) {
@@ -468,13 +493,19 @@ var Aff = function () {
             // Enqueue the appropriate handler. We increase the bracket count
             // because it should not be cancelled.
             case RELEASE:
-              attempts = new Aff(CONS, new Aff(FINALIZED, step, fail), attempts, interrupt);
+              attempts = new Aff(CONS,
+                                 new Aff(FINALIZED,
+                                         step,
+                                         fail),
+                                 attempts,
+                                 interrupt);
               status   = CONTINUE;
               // It has only been killed if the interrupt status has changed
               // since we enqueued the item, and the bracket count is 0. If the
               // bracket count is non-zero then we are in a masked state so it's
               // impossible to be killed.
               if (interrupt && interrupt !== tmp && bracketCount === 0) {
+                console.log(attempt)
                 step = attempt._1.killed(util.fromLeft(interrupt))(attempt._2);
               } else if (fail) {
                 step = attempt._1.failed(util.fromLeft(fail))(attempt._2);

test/Test/Main.purs

@@ -730,6 +730,26 @@ test_regression_kill_empty_supervisor = assert "regression/kill-empty-supervisor
     b = parallel $ delay (Milliseconds 20.0) $> false
   sequential (a <|> b)
 
+test_invincible_completes ∷ Aff Unit
+test_invincible_completes = assert "test/invincible-completes" do
+  ref ← newRef Nothing
+  f1 ← forkAff $
+    generalBracket
+      (pure unit)
+      { killed: \_ _ -> writeRef ref (Just "killed")
+      , failed: \_ _ -> writeRef ref (Just "failed")
+      , completed: \_ _ -> writeRef ref (Just "completed")
+      }
+      (\_ ->
+        bracket
+          (delay (Milliseconds 20.0))
+          (const (pure unit))
+          pure
+      )
+  delay (Milliseconds 10.0)
+  killFiber (error "kaboom.") f1
+  readRef ref <#> (_ == Just "completed")
+
 main ∷ Effect Unit
 main = do
   test_pure
@@ -781,3 +801,4 @@ main = do
     test_regression_kill_sync_async
     test_regression_bracket_kill_mask
     test_regression_kill_empty_supervisor
+    test_invincible_completes