Tweaks to build process

Author: garyb

.gitignore

@@ -1,5 +1,7 @@
 /.*
 !/.gitignore
+!/.jscsrc
+!/.jshintrc
 !/.travis.yml
 /bower_components/
 /node_modules/

.jscsrc

@@ -0,0 +1,12 @@
+{
+  "preset": "grunt",
+  "disallowSpacesInAnonymousFunctionExpression": null,
+  "requireSpacesInAnonymousFunctionExpression": {
+    "beforeOpeningRoundBrace": true,
+    "beforeOpeningCurlyBrace": true
+  },
+  "disallowSpacesInsideObjectBrackets": null,
+  "requireSpacesInsideObjectBrackets": "all",
+  "validateQuoteMarks": "\"",
+  "requireCurlyBraces": null
+}

.jshintrc

@@ -0,0 +1,19 @@
+{
+  "bitwise": true,
+  "eqeqeq": true,
+  "forin": true,
+  "freeze": true,
+  "funcscope": true,
+  "futurehostile": true,
+  "globalstrict": true,
+  "latedef": true,
+  "maxparams": 1,
+  "noarg": true,
+  "nocomma": true,
+  "nonew": true,
+  "notypeof": true,
+  "singleGroups": true,
+  "undef": true,
+  "unused": true,
+  "eqnull": true
+}

.travis.yml

@@ -1,12 +1,14 @@
 language: node_js
+sudo: false
 node_js:
   - 0.10
 env:
-  - TAG=v0.7.0
+  - TAG=v0.7.0 PATH=$HOME/bin:$PATH
 install:
+  - mkdir $HOME/bin
   - wget -O $HOME/purescript.tar.gz https://github.com/purescript/purescript/releases/download/$TAG/linux64.tar.gz
-  - sudo tar zxvf $HOME/purescript.tar.gz -C /usr/local/bin purescript/psc{,i,-docs,-bundle,-publish} --strip-components=1
-  - sudo chmod a+x /usr/local/bin/psc{,i,-docs,-bundle,-publish}
+  - tar zxvf $HOME/purescript.tar.gz -C $HOME/bin purescript/psc{,i,-docs,-bundle,-publish} --strip-components=1
+  - chmod a+x $HOME/bin/psc{,i,-docs,-bundle,-publish}
   - npm install bower gulp -g
   - npm install && bower install
 script:

bower.json

@@ -7,6 +7,10 @@
     "ajax"
   ],
   "license": "Apache 2.0",
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/slamdata/purescript-affjax.git"
+  },
   "ignore": [
     "**/.*",
     "bower_components",
@@ -19,14 +23,15 @@
     "package.json"
   ],
   "dependencies": {
-    "purescript-aff": "~0.11.0",
-    "purescript-arraybuffer-types": "~0.2.0",
-    "purescript-dom": "~0.1.2",
-    "purescript-foreign": "~0.5.0",
-    "purescript-integers": "~0.2.0",
-    "purescript-nullable": "~0.2.0"
+    "purescript-aff": "^0.11.0",
+    "purescript-arraybuffer-types": "^0.2.0",
+    "purescript-dom": "^0.1.2",
+    "purescript-foreign": "^0.5.0",
+    "purescript-integers": "^0.2.0",
+    "purescript-nullable": "^0.2.0",
+    "purescript-unsafe-coerce": "^0.1.0"
   },
   "devDependencies": {
-    "purescript-console": "~0.1.0"
+    "purescript-console": "^0.1.0"
   }
 }

gulpfile.js

@@ -1,60 +1,62 @@
+/* jshint node: true */
 "use strict";
 
 var gulp = require("gulp");
-var plumber = require("gulp-plumber");
+var jshint = require("gulp-jshint");
+var jscs = require("gulp-jscs");
 var purescript = require("gulp-purescript");
-var jsvalidate = require("gulp-jsvalidate");
 
 var sources = [
-  'src/**/*.purs',
-  'bower_components/purescript-*/src/**/*.purs',
-  'test/**/*.purs'
+  "src/**/*.purs",
+  "bower_components/purescript-*/src/**/*.purs",
+  "test/**/*.purs"
 ];
 
 var foreigns = [
-  'src/**/*.js',
-  'bower_components/purescript-*/src/**/*.js',
-  'test/**/*.js'
+  "src/**/*.js",
+  "bower_components/purescript-*/src/**/*.js",
+  "test/**/*.js"
 ];
 
-gulp.task('jsvalidate', function() {
-  return gulp.src(foreigns)
-    .pipe(plumber())
-    .pipe(jsvalidate());
+gulp.task("lint", function() {
+  return gulp.src("src/**/*.js")
+    .pipe(jshint())
+    .pipe(jshint.reporter())
+    .pipe(jscs());
 });
 
-gulp.task('psc', function() {
-  return purescript.psc({
+gulp.task("make", ["lint"], function() {
+  return purescript.psc({ src: sources, ffi: foreigns });
+});
+
+gulp.task("docs", function() {
+  return purescript.pscDocs({
     src: sources,
-    ffi: foreigns
+    docgen: {
+      "Network.HTTP.Affjax": "docs/Network.HTTP.Affjax.md",
+      "Network.HTTP.Affjax.Request": "docs/Network.HTTP.Affjax.Request.md",
+      "Network.HTTP.Affjax.Response": "docs/Network.HTTP.Affjax.Response.md",
+      "Network.HTTP.Method": "docs/Network.HTTP.Method.md",
+      "Network.HTTP.MimeType": "docs/Network.HTTP.MimeType.md",
+      "Network.HTTP.MimeType.Common": "docs/Network.HTTP.MimeType.Common.md",
+      "Network.HTTP.RequestHeader": "docs/Network.HTTP.RequestHeader.md",
+      "Network.HTTP.ResponseHeader": "docs/Network.HTTP.ResponseHeader.md",
+      "Network.HTTP.StatusCode": "docs/Network.HTTP.StatusCode.md"
+    }
   });
 });
 
-gulp.task('pscBundle', function() {
+gulp.task("bundle", ["make"], function() {
   return purescript.pscBundle({
-    src: 'output/**/*.js',
-    output: 'tmp/test.js',
-    main: 'Test.Main'
+    src: "output/**/*.js",
+    output: "tmp/test.js",
+    main: "Test.Main"
   });
 });
 
-gulp.task('pscDocs', function() {
-  return purescript.pscDocs({
-    src: sources,
-    docgen: {
-      'Network.HTTP.Affjax': 'docs/Network.HTTP.Affjax.md',
-      'Network.HTTP.Affjax.Request': 'docs/Network.HTTP.Affjax.Request.md',
-      'Network.HTTP.Affjax.Response': 'docs/Network.HTTP.Affjax.Response.md',
-      'Network.HTTP.Method': 'docs/Network.HTTP.Method.md',
-      'Network.HTTP.MimeType': 'docs/Network.HTTP.MimeType.md',
-      'Network.HTTP.MimeType.Common': 'docs/Network.HTTP.MimeType.Common.md',
-      'Network.HTTP.RequestHeader': 'docs/Network.HTTP.RequestHeader.md',
-      'Network.HTTP.ResponseHeader': 'docs/Network.HTTP.ResponseHeader.md',
-      'Network.HTTP.StatusCode': 'docs/Network.HTTP.StatusCode.md'
-    }
-  })
+gulp.task("dotpsci", function () {
+  return purescript.psci({ src: sources, ffi: foreigns })
+    .pipe(gulp.dest("."));
 });
 
-gulp.task('make', ['jsvalidate', 'psc', 'pscDocs']);
-gulp.task('test', ['jsvalidate', 'psc', 'pscBundle', 'pscDocs']);
-gulp.task('default', ['make']);
+gulp.task("default", ["bundle", "docs", "dotpsci"]);

package.json

@@ -2,7 +2,8 @@
   "private": true,
   "devDependencies": {
     "gulp": "^3.8.11",
-    "gulp-jsvalidate": "^2.0.0",
+    "gulp-jscs": "^1.6.0",
+    "gulp-jshint": "^1.11.2",
     "gulp-plumber": "^1.0.0",
     "gulp-purescript": "^0.5.0"
   }

src/Network/HTTP/Affjax.js

@@ -1,17 +1,20 @@
+/* jshint browser: true */
+/* global exports */
 "use strict";
 
 // module Network.HTTP.Affjax
 
-exports._ajax = function(mkHeader, options, canceler, errback, callback) {
+// jshint maxparams: 5
+exports._ajax = function (mkHeader, options, canceler, errback, callback) {
   return function () {
     var xhr = new XMLHttpRequest();
     xhr.open(options.method || "GET", options.url || "/", true, options.username, options.password);
     if (options.headers) {
-      for (var i = 0, header; header = options.headers[i]; i++) {
+      for (var i = 0, header; (header = options.headers[i]) != null; i++) {
         xhr.setRequestHeader(header.field, header.value);
       }
     }
-    xhr.onerror = function (err) {
+    xhr.onerror = function () {
       errback(new Error("AJAX request failed: " + options.method + " " + options.url))();
     };
     xhr.onload = function () {
@@ -32,9 +35,10 @@ exports._ajax = function(mkHeader, options, canceler, errback, callback) {
     xhr.send(options.content);
     return canceler(xhr);
   };
-}
+};
 
-exports._cancelAjax = function(xhr, cancelError, errback, callback) {
+// jshint maxparams: 4
+exports._cancelAjax = function (xhr, cancelError, errback, callback) {
   return function () {
     try { xhr.abort(); } catch (e) { return callback(false)(); }
     return callback(true)();

src/Network/HTTP/Affjax/Request.js

@@ -7,6 +7,7 @@ import Prelude
 import DOM (Document())
 import DOM.File (Blob())
 import DOM.XHR (FormData())
+import qualified Unsafe.Coerce as U
 import qualified Data.ArrayBuffer.Types as A
 
 -- | Type representing all content types that be sent via XHR (ArrayBufferView,
@@ -22,45 +23,43 @@ instance requestableRequestContent :: Requestable RequestContent where
   toRequest = id
 
 instance requestableInt8Array :: Requestable (A.ArrayView A.Int8) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableInt16Array :: Requestable (A.ArrayView A.Int16) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableInt32Array :: Requestable (A.ArrayView A.Int32) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableUint8Array :: Requestable (A.ArrayView A.Uint8) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableUint16Array :: Requestable (A.ArrayView A.Uint16) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableUint32Array :: Requestable (A.ArrayView A.Uint32) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableUint8ClampedArray :: Requestable (A.ArrayView A.Uint8Clamped) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableFloat32Array :: Requestable (A.ArrayView A.Float32) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableFloat64Array :: Requestable (A.ArrayView A.Float64) where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableBlob :: Requestable Blob where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableDocument :: Requestable Document where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableString :: Requestable String where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableFormData :: Requestable FormData where
-  toRequest = unsafeConversion
+  toRequest = U.unsafeCoerce
 
 instance requestableUnit :: Requestable Unit where
-  toRequest = unsafeConversion
-
-foreign import unsafeConversion :: forall a b. a -> b
+  toRequest = U.unsafeCoerce