Fix hasOwnProperty bug again and forever

Author: no-longer-on-githu-b

src/Data/StrMap.js

@@ -6,7 +6,7 @@
 exports._copy = function (m) {
   var r = {};
   for (var k in m) {
-    if (m.hasOwnProperty(k)) {
+    if ({}.hasOwnProperty.call(m, k)) {
       r[k] = m[k];
     }
   }
@@ -17,7 +17,7 @@ exports._copyEff = function (m) {
   return function () {
     var r = {};
     for (var k in m) {
-      if (m.hasOwnProperty(k)) {
+      if ({}.hasOwnProperty.call(m, k)) {
         r[k] = m[k];
       }
     }
@@ -35,7 +35,7 @@ exports.runST = function (f) {
 exports._fmapStrMap = function (m0, f) {
   var m = {};
   for (var k in m0) {
-    if (m0.hasOwnProperty(k)) {
+    if ({}.hasOwnProperty.call(m0, k)) {
       m[k] = f(m0[k]);
     }
   }
@@ -46,7 +46,7 @@ exports._fmapStrMap = function (m0, f) {
 exports._mapWithKey = function (m0, f) {
   var m = {};
   for (var k in m0) {
-    if (m0.hasOwnProperty(k)) {
+    if ({}.hasOwnProperty.call(m0, k)) {
       m[k] = f(k)(m0[k]);
     }
   }
@@ -65,7 +65,7 @@ exports._foldM = function (bind) {
           };
         }
         for (var k in m) {
-          if (m.hasOwnProperty(k)) {
+          if ({}.hasOwnProperty.call(m, k)) {
             acc = bind(acc)(g(k));
           }
         }
@@ -78,7 +78,7 @@ exports._foldM = function (bind) {
 // jshint maxparams: 4
 exports._foldSCStrMap = function (m, z, f, fromMaybe) {
   for (var k in m) {
-    if (m.hasOwnProperty(k)) {
+    if ({}.hasOwnProperty.call(m, k)) {
       var maybeR = f(z)(k)(m[k]);
       var r = fromMaybe(null)(maybeR);
       if (r === null) return z;
@@ -92,7 +92,7 @@ exports._foldSCStrMap = function (m, z, f, fromMaybe) {
 exports.all = function (f) {
   return function (m) {
     for (var k in m) {
-      if (m.hasOwnProperty(k) && !f(k)(m[k])) return false;
+      if ({}.hasOwnProperty.call(m, k) && !f(k)(m[k])) return false;
     }
     return true;
   };
@@ -101,7 +101,7 @@ exports.all = function (f) {
 exports.size = function (m) {
   var s = 0;
   for (var k in m) {
-    if (m.hasOwnProperty(k)) {
+    if ({}.hasOwnProperty.call(m, k)) {
       ++s;
     }
   }
@@ -130,7 +130,7 @@ function _collect(f) {
   return function (m) {
     var r = [];
     for (var k in m) {
-      if (m.hasOwnProperty(k)) {
+      if ({}.hasOwnProperty.call(m, k)) {
         r.push(f(k)(m[k]));
       }
     }

test/Test/Data/StrMap.purs

@@ -34,7 +34,8 @@ instance showInstruction :: (Show k, Show v) => Show (Instruction k v) where
 instance arbInstruction :: (Arbitrary v) => Arbitrary (Instruction String v) where
   arbitrary = do
     b <- arbitrary
-    k <- arbitrary
+    kIshasOwnProperty <- (&&) <$> arbitrary <*> arbitrary
+    k <- if kIshasOwnProperty then pure "hasOwnProperty" else arbitrary
     case b of
       true -> do
         v <- arbitrary