Skip to content

Commit a7b68a7

Browse files
committed
fixes partiality/FFI issue (by removing explicit Partial)
1 parent c646fb6 commit a7b68a7

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/Web/DOM/DOMParser.purs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@ module Web.DOM.DOMParser
77
, parseXMLFromString
88
) where
99

10-
import Prelude
10+
--import Prelude
1111

1212
import Effect (Effect)
13-
import Partial.Unsafe (unsafePartial)
1413
import Web.DOM.Document (Document)
1514

1615
foreign import data DOMParserType
@@ -19,22 +18,22 @@ foreign import data DOMParser ∷ Type
1918
foreign import makeDOMParser Effect DOMParser
2019

2120
--| Parse a string with the first argumet being a string for a doctype
22-
foreign import parseFromString Partial String String DOMParser Document
21+
foreign import parseFromString String String DOMParser Document
2322

2423
--| Convience function to parse HTML from a string, partially applying
2524
--| `parseFromString` with "text/html"
2625
parseHTMLFromString String DOMParser Document
2726
parseHTMLFromString s d =
28-
unsafePartial $ parseFromString "text/html" s d
27+
parseFromString "text/html" s d
2928

3029
--| Convience function to parse SVG from a string, partially applying
3130
--| `parseFromString` with "image/svg+xml"
3231
parseSVGFromString String DOMParser Document
3332
parseSVGFromString s d =
34-
unsafePartial $ parseFromString "image/svg+xml" s d
33+
parseFromString "image/svg+xml" s d
3534

3635
--| Convience function to parse XML from a string, partially applying
3736
--| `parseFromString` with "application/xml"
3837
parseXMLFromString String DOMParser Document
3938
parseXMLFromString s d=
40-
unsafePartial $ parseFromString "application/xml" s d
39+
parseFromString "application/xml" s d

test/Data.purs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
module Test.Data where
22

33
noteXml :: String
4-
noteXml = """
5-
<?xml version="1.0" encoding="UTF-8"?>
4+
noteXml = """<?xml version="1.0" encoding="UTF-8"?>
65
<note>
76
<to>Tove</to>
87
<from>Jani</from>

0 commit comments

Comments
 (0)