Fix windows

Author: f-f

src/Spago/Command/Run.purs

@@ -1,6 +1,7 @@
 module Spago.Command.Run
   ( getNode
   , run
+  , encodeFileUrlPath
   , RunEnv
   , Node
   , RunOptions
@@ -13,6 +14,7 @@ import Data.Array as Array
 import Data.Array.NonEmpty as NEA
 import Data.Map as Map
 import Data.String as String
+import Data.String.CodeUnits as SCU
 import JSURI (encodeURIComponent)
 import Node.FS.Perms as Perms
 import Registry.Version as Version
@@ -48,6 +50,26 @@ type RunOptions =
 
 type Node = { cmd :: GlobalPath, version :: Version }
 
+-- | Encode a file path for use in a file:// URL.
+-- | Encodes special characters (spaces, apostrophes, etc.) but preserves
+-- | Windows drive letters (e.g., "C:") since encoding the colon breaks URLs.
+encodeFileUrlPath :: String -> String
+encodeFileUrlPath str =
+  String.split (String.Pattern "/") str
+    # map encodeSegment
+    # String.joinWith "/"
+  where
+  encodeSegment seg
+    | isWindowsDrive seg = seg
+    | otherwise = fromMaybe seg (encodeURIComponent seg)
+
+  -- Windows drive letter: single ASCII letter followed by colon (e.g., "C:", "D:")
+  isWindowsDrive seg = case SCU.toCharArray seg of
+    [ letter, ':' ] -> isAsciiLetter letter
+    _ -> false
+
+  isAsciiLetter c = (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z')
+
 nodeVersion :: forall a. Spago (LogEnv a) Version
 nodeVersion =
   Cmd.exec (Path.global "node") [ "--version" ] Cmd.defaultExecOptions { pipeStdout = false, pipeStderr = false } >>= case _ of
@@ -85,13 +107,6 @@ run = do
 
         nodeArgs = [ Path.toRaw runJsPath ] <> opts.execArgs
 
-        -- Encode each path segment for use in file:// URL
-        -- Splits on /, encodes each segment, rejoins with /
-        encodeFileUrlPath str =
-          String.split (String.Pattern "/") str
-            # map (\seg -> fromMaybe seg (encodeURIComponent seg))
-            # String.joinWith "/"
-
         nodeContents =
           Array.fold
             [ "import { main } from 'file://"

test/Spago/Unit.purs

@@ -9,6 +9,7 @@ import Test.Spago.Unit.Init as Init
 import Test.Spago.Unit.NodeVersion as NodeVersion
 import Test.Spago.Unit.Path as Path
 import Test.Spago.Unit.Printer as Printer
+import Test.Spago.Unit.Run as Run
 import Test.Spec (Spec)
 import Test.Spec as Spec
 
@@ -21,3 +22,4 @@ spec = Spec.describe "unit" do
   Git.spec
   Path.spec
   NodeVersion.spec
+  Run.spec

test/Spago/Unit/Run.purs

@@ -0,0 +1,41 @@
+module Test.Spago.Unit.Run where
+
+import Test.Prelude
+
+import Spago.Command.Run (encodeFileUrlPath)
+import Test.Spec (Spec)
+import Test.Spec as Spec
+
+spec :: Spec Unit
+spec = Spec.describe "Run" do
+
+  Spec.describe "encodeFileUrlPath" do
+
+    Spec.it "encodes spaces" do
+      encodeFileUrlPath "/path/with spaces/file" `shouldEqual` "/path/with%20spaces/file"
+
+    Spec.it "encodes apostrophes" do
+      encodeFileUrlPath "/Volumes/Tim's Docs/project" `shouldEqual` "/Volumes/Tim%27s%20Docs/project"
+
+    Spec.it "encodes hash symbols" do
+      encodeFileUrlPath "/path/test#1/file" `shouldEqual` "/path/test%231/file"
+
+    Spec.it "encodes brackets" do
+      encodeFileUrlPath "/path/test[dev]/file" `shouldEqual` "/path/test%5Bdev%5D/file"
+
+    Spec.it "preserves Windows drive letters" do
+      encodeFileUrlPath "C:/Users/test" `shouldEqual` "C:/Users/test"
+      encodeFileUrlPath "D:/a/spago/output" `shouldEqual` "D:/a/spago/output"
+
+    Spec.it "preserves Windows drive letters with special chars in path" do
+      encodeFileUrlPath "C:/Users/Tim's Folder/project" `shouldEqual` "C:/Users/Tim%27s%20Folder/project"
+
+    Spec.it "handles lowercase drive letters" do
+      encodeFileUrlPath "c:/users/test" `shouldEqual` "c:/users/test"
+
+    Spec.it "encodes colon in non-drive-letter segments" do
+      -- A colon not at the start as a drive letter should be encoded
+      encodeFileUrlPath "/path/file:name/test" `shouldEqual` "/path/file%3Aname/test"
+
+    Spec.it "leaves normal paths unchanged" do
+      encodeFileUrlPath "/home/user/project/output" `shouldEqual` "/home/user/project/output"