Skip to content

Commit 16b6a9e

Browse files
Merge pull request #409 from purple-technology/fcc
refactor: adding props with children for Tag and ClosableItem components
2 parents 2e67616 + 3907eb6 commit 16b6a9e

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
### [5.24.1](https://github.com/purple-technology/phoenix-components/compare/v5.24.0...v5.24.1) (2025-05-23)
6+
57
## [5.24.0](https://github.com/purple-technology/phoenix-components/compare/v5.23.0...v5.24.0) (2025-03-26)
68

79

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@purple/phoenix-components",
3-
"version": "5.24.0",
3+
"version": "5.24.1",
44
"description": "",
55
"main": "dist/bundle.umd.js",
66
"module": "dist/bundle.esm.js",

src/components/ClosableItem/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react'
1+
import React, { PropsWithChildren } from 'react'
22

33
import iconTimes from '../../images/times.svg'
44
import { GenericComponentProps } from '../../interfaces/GenericComponentProps'
@@ -9,7 +9,7 @@ export interface ClosableItemProps extends GenericComponentProps {
99
onClose?: React.MouseEventHandler<HTMLButtonElement>
1010
}
1111

12-
export const ClosableItem: React.FC<ClosableItemProps> = ({
12+
export const ClosableItem: React.FC<PropsWithChildren<ClosableItemProps>> = ({
1313
testId = 'ClosableItem',
1414
className,
1515
onClose,

src/components/Tag/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react'
1+
import React, { PropsWithChildren } from 'react'
22

33
import { GenericComponentProps } from '../../interfaces/GenericComponentProps'
44
import { ColorTheme } from '../../types/Color'
@@ -13,7 +13,7 @@ export interface TagProps extends GenericComponentProps, MarginProps {
1313
outline?: boolean
1414
}
1515

16-
export const Tag: React.FC<TagProps> = ({
16+
export const Tag: React.FC<PropsWithChildren<TagProps>> = ({
1717
colorTheme = 'brand',
1818
size = 'md',
1919
testId = 'Tag',

0 commit comments

Comments
 (0)