Fix mimalloc build failure with musl and release mode #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this flag is breaking windows builds. Can you please change it to be removed on windows? |
|
I've made another commit,please run the tests. |
|
@octavonce it would be great if you could release this to crates.io, aarch64-unknown-linux-gnu is also affected 🙏 |
Add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with mimalloc as the allocator targeting musl in release mode, the compiler fails due to -Werror=date-time warnings caused by mimalloc's use of DATE and TIME macros. This conflicts with musl's reproducible builds requirements.
This commit adds the -Wno-error=date-time flag to the build configuration to downgrade these specific warnings from errors to warnings. This allows successful compilation while maintaining the functionality of mimalloc.
The change affects only musl targets in release mode and does not alter behavior for other targets or build profiles.
Fixes compilation error: expansion of date/time macro in mimalloc with musl + release combination.