Skip to content

Commit 24d5adf

Browse files
committed
chore: Modifications after rebasing on original branch
1 parent addca6e commit 24d5adf

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data.Tests/SpannerBatchCommandTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ public void TransactionConstructor()
5353
{
5454
var connection = new SpannerConnection();
5555
SpannerClient fakeClient = ManagedSessionTests.CreateFakeClient();
56-
ManagedSession fakeManagedSession = new ManagedSession(fakeClient, null, null, null);
56+
DatabaseName dbName = ManagedSessionTests.FetchTestDatabaseName();
57+
ManagedSession fakeManagedSession = new ManagedSession(fakeClient, dbName, null, null);
5758
ManagedTransaction managedTransaction = new ManagedTransaction(fakeManagedSession, null, null, false, null);
5859

5960
var transaction = new SpannerTransaction(connection, managedTransaction, SpannerTransactionCreationOptions.ReadWrite, transactionOptions: null, isRetriable: false);

apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data.Tests/V1/ManagedSessionTests.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,20 @@ internal static SpannerClient CreateFakeClient()
6161
return fakeClient;
6262
}
6363

64-
internal async Task<ManagedSession> FetchTestMultiplexSessionAsync(SpannerClient client = null)
64+
internal static DatabaseName FetchTestDatabaseName()
6565
{
6666
if (!DatabaseName.TryParse(TestDatabase, out var databaseName))
6767
{
6868
throw new Exception($"Unable to parse string to DatabaseName {TestDatabase}");
6969
}
7070

71+
return databaseName;
72+
}
73+
74+
internal async Task<ManagedSession> FetchTestMultiplexSessionAsync(SpannerClient client = null)
75+
{
76+
var databaseName = FetchTestDatabaseName();
77+
7178
if (client == null)
7279
{
7380
client = CreateFakeClient();

apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data/SessionPoolManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ static SessionPoolManager()
4949
/// is specified on construction.
5050
/// </summary>
5151
public static SessionPoolManager Default { get; } =
52-
new SessionPoolManager(new SessionPoolOptions(), CreateDefaultSpannerSettings(), Logger.DefaultLogger, CreateClientAsync);
52+
new SessionPoolManager(new ManagedSessionOptions(), CreateDefaultSpannerSettings(), Logger.DefaultLogger, CreateClientAsync);
5353

5454
private readonly Func<SpannerClientCreationOptions, SpannerSettings, Task<SpannerClient>> _clientFactory;
5555

apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data/SpannerConnection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ internal Task<SpannerTransaction> BeginTransactionAsyncImpl(
607607
SpannerTransactionCreationOptions effectiveCreationOptions = transactionCreationOptions;
608608
ManagedTransaction transaction = transactionCreationOptions.TransactionId is null ?
609609
await AcquireManagedTransaction(transactionCreationOptions, out effectiveCreationOptions).ConfigureAwait(false) :
610-
await _managedSession.CreateManagedTransactionWithMode(ByteString.FromBase64(effectiveCreationOptions.TransactionId.Id), ModeOneofCase.ReadOnly).ConfigureAwait(false);
610+
await _managedSession.CreateManagedTransaction(ByteString.FromBase64(effectiveCreationOptions.TransactionId.Id), ModeOneofCase.ReadOnly).ConfigureAwait(false);
611611

612612
return new SpannerTransaction(this, transaction, effectiveCreationOptions, transactionOptions, isRetriable: false);
613613
}, "SpannerConnection.BeginTransactionAsync", Logger);
@@ -1084,10 +1084,10 @@ internal Task<ManagedTransaction> AcquireManagedTransaction(SpannerTransactionCr
10841084
// If we already have a transaction, we need to create a ManagedTransaction object around this transactionId.
10851085

10861086
transactionIdBytes = ByteString.FromBase64(effectiveCreationOptions.TransactionId.Id);
1087-
return _managedSession.CreateManagedTransactionWithSpannerTransaction(transactionIdBytes, effectiveCreationOptions.GetTransactionOptions(), effectiveCreationOptions?.IsSingleUse == true);
1087+
return _managedSession.CreateManagedTransaction(transactionIdBytes, effectiveCreationOptions.GetTransactionOptions(), effectiveCreationOptions?.IsSingleUse == true);
10881088
}
10891089

1090-
return _managedSession.CreateManagedTransactionWithOptions(effectiveCreationOptions?.GetTransactionOptions(), effectiveCreationOptions?.IsSingleUse == true);
1090+
return _managedSession.CreateManagedTransaction(effectiveCreationOptions?.GetTransactionOptions(), effectiveCreationOptions?.IsSingleUse == true);
10911091
//return new ManagedTransaction(_managedSession, transactionIdBytes, effectiveCreationOptions?.GetTransactionOptions(), effectiveCreationOptions?.IsSingleUse == true, null);
10921092
}
10931093

0 commit comments

Comments
 (0)