Skip to content

Commit 87be3ef

Browse files
authored
Migrate away from Play Core SDK (#334)
To avoid warning from google play when the app is targeting SDK 34+
1 parent 50b24fd commit 87be3ef

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Changelog
22

33
- Unreleased
4-
- Nothing yet
4+
- [PR #334](https://github.com/pushandplay/cordova-plugin-apprate/pull/334) - Migration from the Play Core Java
55

66
- v1.7.3
77
- [PR #315](https://github.com/pushandplay/cordova-plugin-apprate/pull/315) - Fix error in IOS 17 "Call must be made on main thread" in launchAppStore method

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ AppRate.setPreferences({
6363
- From github repository: `cordova plugin add https://github.com/pushandplay/cordova-plugin-apprate.git`
6464
- For phonegap build add the following to your config.xml: `<gap:plugin name="cordova-plugin-apprate" />`
6565

66-
## Integrating Google Play Core
66+
## Integrating Play In-App Reviews Library
6767

68-
To set up Google Play Core version, you can use PLAY_CORE_VERSION parameter (with `1.+` value by default). It is useful in order to avoid conflicts with another plugins which use any other different version of Google Play Core.
68+
To set up Play In-App Reviews Library version, you can use PLAY_REVIEW_VERSION parameter (with `2.+` value by default). It is useful in order to avoid conflicts with another plugins which use any other different version of Play In-App Reviews Library. For Play In-App Reviews Library release notes please see https://developer.android.com/reference/com/google/android/play/core/release-notes-in_app_reviews
6969

7070
## Customization and usage
7171

plugin.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ under the License.
5050
</js-module>
5151

5252
<platform name="android">
53-
<preference name="PLAY_CORE_VERSION" default="1.+"/>
54-
<framework src="com.google.android.play:core:$PLAY_CORE_VERSION" />
53+
<preference name="PLAY_REVIEW_VERSION" default="2.+" />
54+
<framework src="com.google.android.play:review:$PLAY_REVIEW_VERSION" />
5555
<source-file src="src/android/AppRate.java" target-dir="src/org/pushandplay/cordova/apprate"/>
5656

5757
<config-file target="res/xml/config.xml" parent="/*">

src/android/AppRate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import com.google.android.play.core.review.ReviewInfo;
1616
import com.google.android.play.core.review.ReviewManager;
1717
import com.google.android.play.core.review.ReviewManagerFactory;
18-
import com.google.android.play.core.tasks.Task;
18+
import com.google.android.gms.tasks.Task;
1919

2020
public class AppRate extends CordovaPlugin {
2121
@Override

0 commit comments

Comments
 (0)