Merge pull request #18 from push-protocol/arya/ue-test

test: add unit tests for MsgServer of UE module

Author: 0xNilesh

x/ue/keeper/genesis_test.go

@@ -3,6 +3,7 @@ package keeper_test
 import (
 	"testing"
 
+	"github.com/golang/mock/gomock"
 	"github.com/rollchains/pchain/x/ue/types"
 	"github.com/stretchr/testify/require"
 )
@@ -13,7 +14,9 @@ func TestGenesis(t *testing.T) {
 	genesisState := &types.GenesisState{
 		Params: types.DefaultParams(),
 	}
-
+	f.mockEVMKeeper.EXPECT().SetAccount(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
+	f.mockEVMKeeper.EXPECT().SetCode(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
+	f.mockEVMKeeper.EXPECT().SetState(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	f.k.InitGenesis(f.ctx, genesisState)
 
 	got := f.k.ExportGenesis(f.ctx)

x/ue/keeper/keeper_test.go

@@ -5,6 +5,8 @@ import (
 	"math/big"
 	"testing"
 
+	"github.com/golang/mock/gomock"
+
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/stretchr/testify/suite"
 
@@ -34,6 +36,7 @@ import (
 	"github.com/rollchains/pchain/app"
 	module "github.com/rollchains/pchain/x/ue"
 	"github.com/rollchains/pchain/x/ue/keeper"
+	"github.com/rollchains/pchain/x/ue/keeper/mocks"
 	"github.com/rollchains/pchain/x/ue/types"
 
 	"github.com/ethereum/go-ethereum/accounts/abi"
@@ -65,12 +68,24 @@ type testFixture struct {
 	addrs      []sdk.AccAddress
 	govModAddr string
 	evmAddrs   []common.Address
+
+	ctrl           *gomock.Controller
+	mockBankKeeper *mocks.MockBankKeeper
+	mockUTVKeeper  *mocks.MockUtvKeeper
+	mockEVMKeeper  *mocks.MockEVMKeeper
 }
 
 func SetupTest(t *testing.T) *testFixture {
 	t.Helper()
 	f := new(testFixture)
 
+	f.ctrl = gomock.NewController(t)
+	t.Cleanup(f.ctrl.Finish)
+
+	f.mockBankKeeper = mocks.NewMockBankKeeper(f.ctrl)
+	f.mockUTVKeeper = mocks.NewMockUtvKeeper(f.ctrl)
+	f.mockEVMKeeper = mocks.NewMockEVMKeeper(f.ctrl)
+
 	cfg := sdk.GetConfig() // do not seal, more set later
 	cfg.SetBech32PrefixForAccount(app.Bech32PrefixAccAddr, app.Bech32PrefixAccPub)
 	cfg.SetBech32PrefixForValidator(app.Bech32PrefixValAddr, app.Bech32PrefixValPub)
@@ -101,10 +116,10 @@ func SetupTest(t *testing.T) *testFixture {
 	registerBaseSDKModules(logger, f, encCfg, keys, accountAddressCodec, validatorAddressCodec, consensusAddressCodec)
 
 	// Setup Keeper.
-	f.k = keeper.NewKeeper(encCfg.Codec, runtime.NewKVStoreService(keys[types.ModuleName]), logger, f.govModAddr, MockEVMKeeper{}, &feemarketkeeper.Keeper{}, f.bankkeeper, &MockUTVKeeper{})
+	f.k = keeper.NewKeeper(encCfg.Codec, runtime.NewKVStoreService(keys[types.ModuleName]), logger, f.govModAddr, f.mockEVMKeeper, &feemarketkeeper.Keeper{}, f.mockBankKeeper, f.mockUTVKeeper)
 	f.msgServer = keeper.NewMsgServerImpl(f.k)
 	f.queryServer = keeper.NewQuerier(f.k)
-	f.appModule = module.NewAppModule(encCfg.Codec, f.k, MockEVMKeeper{}, &feemarketkeeper.Keeper{}, &f.bankkeeper, &MockUTVKeeper{})
+	f.appModule = module.NewAppModule(encCfg.Codec, f.k, f.mockEVMKeeper, &feemarketkeeper.Keeper{}, f.mockBankKeeper, f.mockUTVKeeper)
 
 	return f
 }
@@ -197,8 +212,13 @@ func (m MockEVMKeeper) CallEVM(
 	method string,
 	args ...interface{},
 ) (*evmtypes.MsgEthereumTxResponse, error) {
+
+	addr := common.HexToAddress("0x1234567890abcdef1234567890abcdef12345678")
+
+	// ABI‑style left‑pad to 32 bytes
+	padded := common.LeftPadBytes(addr.Bytes(), 32)
 	return &evmtypes.MsgEthereumTxResponse{
-		Ret: []byte{0x01, 0x02},
+		Ret: padded, // flag : need to correct his mock for MintPC test
 	}, nil
 }
 
@@ -211,3 +231,19 @@ func (m *MockUTVKeeper) VerifyGatewayInteractionTx(ctx context.Context, owner st
 func (m *MockUTVKeeper) VerifyAndGetLockedFunds(ctx context.Context, ownerKey, txHash, chain string) (big.Int, uint32, error) {
 	return *big.NewInt(0), 0, nil // simulate a pass-through
 }
+
+type MockBankKeeper struct{}
+
+func (m MockBankKeeper) MintCoins(ctx context.Context, moduleName string, amt sdk.Coins) error {
+	return nil
+}
+func (m MockBankKeeper) SendCoinsFromAccountToModule(ctx context.Context, senderAddr sdk.AccAddress, recipientModule string, amt sdk.Coins) error {
+	return nil
+}
+
+func (m MockBankKeeper) SendCoinsFromModuleToAccount(ctx context.Context, senderAddr string, recipientAddr sdk.AccAddress, amt sdk.Coins) error {
+	return nil
+}
+func (m MockBankKeeper) BurnCoins(ctx context.Context, moduleName string, amt sdk.Coins) error {
+	return nil
+}