Skip to content

quick fix - rewards s2#2031

Merged
riyanshu-patro merged 1 commit intomainfrom
quick-fix-s2
Mar 21, 2025
Merged

quick fix - rewards s2#2031
riyanshu-patro merged 1 commit intomainfrom
quick-fix-s2

Conversation

@riyanshu-patro
Copy link
Copy Markdown
Collaborator

@riyanshu-patro riyanshu-patro commented Mar 20, 2025

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2025

  • In the import section, 'blocks' should be imported as 'blocks' and not as 'sonner': 
    import { toast, Toaster } from 'blocks';
  • The CSS property should be 'border-radius' instead of 'border-radius' in the 'IconContainer' component: 
    border-radius: var(--radius-xxs) var(--radius-none) var(--radius-none) var(--radius-xxs);
  • In the 'NotificationItem' component, the 'notification.hide()' call should be 'notification.hide' without parentheses: 
    const handleNotificationClose = () => {
  onClose?.();
  notification.hide;
};
  • The 'Container' styled component should have some styles to define: 
    const Container = styled.div`
  /* Add styling for the container if needed */
`;
  • The 'useRewardsNotification' function is missing the return statement at the end: 
    export const useRewardsNotification = () => {
  // Function logic

  return;
};

All looks good.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2025 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-03-21 08:15 UTC

@abhishek-01k abhishek-01k self-requested a review March 21, 2025 08:14
@riyanshu-patro riyanshu-patro merged commit 117fba3 into main Mar 21, 2025
2 of 3 checks passed
@riyanshu-patro riyanshu-patro deleted the quick-fix-s2 branch March 21, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corlard3y corlard3y corlard3y approved these changes

@abhishek-01k abhishek-01k abhishek-01k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@riyanshu-patro @corlard3y @abhishek-01k