Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Docs out of date for v0.3.0 #67

@cep21

Description

@cep21

Docs mention node-role.kubernetes.io/worker=true, but the code for v0.3.0 expects kubernetes.io/role=worker by default (https://github.com/pusher/k8s-spot-rescheduler/blob/v0.3.0/nodes/nodes.go#L31)

Also the example deployment https://github.com/pusher/k8s-spot-rescheduler/blob/master/deploy/deployment.yaml#L31 could change the block

          command:
            - rescheduler
            - -v=2
            - --running-in-cluster=true
            - --namespace=kube-system
            - --housekeeping-interval=10s
            - --node-drain-delay=10m
            - --pod-eviction-timeout=2m
            - --max-graceful-termination=2m
            - --listen-address=0.0.0.0:9235
            - --on-demand-node-label=node-role.kubernetes.io/worker
            - --spot-node-label=node-role.kubernetes.io/spot-worker

into

          args:
            - -v=2
            - --running-in-cluster=true
            - --namespace=kube-system
            - --housekeeping-interval=10s
            - --node-drain-delay=10m
            - --pod-eviction-timeout=2m
            - --max-graceful-termination=2m
            - --listen-address=0.0.0.0:9235
            - --on-demand-node-label=node-role.kubernetes.io/worker
            - --spot-node-label=node-role.kubernetes.io/spot-worker

to both resolve the issue with the binary being renamed (away from rescheduler see #64 (comment)) and to be resistant from future binary renames.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions