fixup

move delete to partial as not everything is deletable
fix library genre test
fix delete media.

Author: Hellowlol

plexapi/base.py

@@ -251,14 +251,6 @@ def _castAttrValue(self, op, query, value):
     def _loadData(self, data):
         raise NotImplementedError('Abstract method not implemented.')
 
-    def delete(self):
-        try:
-            return self._server.query(self.key, method=self._server._session.delete)
-        except BadRequest:
-            log.error("Failed to delete %s. This could be because you havn't allowed "
-                      "items to be deleted" % self.key)
-            raise
-
 
 class PlexPartialObject(PlexObject):
     """ Not all objects in the Plex listings return the complete list of elements
@@ -267,6 +259,14 @@ class PlexPartialObject(PlexObject):
         automatically and update itself.
     """
 
+    def delete(self):
+        try:
+            return self._server.query(self.key, method=self._server._session.delete)
+        except BadRequest:
+            log.error("Failed to delete %s. This could be because you havn't allowed "
+                      "items to be deleted" % self.key)
+            raise
+
     def __eq__(self, other):
         return other is not None and self.key == other.key
 

tests/conftest.py

@@ -163,6 +163,7 @@ def monkeydownload(request, monkeypatch):
 
 
 def callable_http_patch():
+    """This intented to stop some http requests inside some tests."""
     return patch('plexapi.server.requests.sessions.Session.send',
                  return_value=MagicMock(status_code=200,
                  text='<xml><child></child></xml>'))
@@ -176,6 +177,7 @@ def empty_response(mocker):
 
 @pytest.fixture()
 def patched_http_call(mocker):
+    """This will stop any http calls inside any test."""
     return mocker.patch('plexapi.server.requests.sessions.Session.send',
                         return_value=MagicMock(status_code=200,
                                                text='<xml><child></child></xml>')

tests/test_library.py

@@ -128,8 +128,7 @@ def test_library_MovieSection_refresh(movies, patched_http_call):
 
 
 def test_library_MovieSection_search_genre(movie, movies):
-    # assert len(movie.genres[0].items()) # TODO
-    assert len(movies.search(genre=movie.genres[0])) > 1
+    assert len(movies.search(genre=animation[0])) > 1
 
 
 def test_library_MovieSection_cancelUpdate(movies):

tests/test_video.py

@@ -64,9 +64,9 @@ def test_video_Movie_delete_part(movie, mocker):
     # we need to reload this as there is a bug in part.delete
     # See https://github.com/pkkid/python-plexapi/issues/201
     m = movie.reload()
-    for part in m.iterParts():
+    for media in m.media:
         with utils.callable_http_patch():
-            part.delete()
+            media.delete()
 
 
 def test_video_Movie_iterParts(movie):