Skip to content

Commit 67d3895

Browse files
authored
Fix library image tests and system account test (#1545)
* Fix library art and thumb tests Library artwork and thumbnail is no longer returned in the `/library/sections/all` XML data on newer versions of PMS. * Fix system account name test The default system account with ID == 0 has a blank name on newer versions of PMS.
1 parent 8f2903d commit 67d3895

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/test_library.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ def test_library_sectionByID_with_attrs(plex, movies):
3232
# This seems to fail for some reason.
3333
# my account allow of sync, didn't find any about settings about the library.
3434
# assert movies.allowSync is ("sync" in plex.ownerFeatures)
35-
assert movies.art == "/:/resources/movie-fanart.jpg"
36-
assert utils.is_metadata(
35+
assert movies.art in ("/:/resources/movie-fanart.jpg", None)
36+
assert movies.composite is None or utils.is_metadata(
3737
movies.composite, prefix="/library/sections/", contains="/composite/"
3838
)
3939
assert utils.is_datetime(movies.createdAt)
@@ -46,7 +46,7 @@ def test_library_sectionByID_with_attrs(plex, movies):
4646
assert movies.refreshing is False
4747
assert movies.scanner == "Plex Movie"
4848
assert movies._server._baseurl == utils.SERVER_BASEURL
49-
assert movies.thumb == "/:/resources/movie.png"
49+
assert movies.thumb in ("/:/resources/movie.png", None)
5050
assert movies.title == "Movies"
5151
assert movies.type == "movie"
5252
assert utils.is_datetime(movies.updatedAt)
@@ -561,13 +561,13 @@ def test_library_section_timeline(plex, movies):
561561
assert tl.TAG == "LibraryTimeline"
562562
assert tl.size > 0
563563
assert tl.allowSync is False
564-
assert tl.art == "/:/resources/movie-fanart.jpg"
564+
assert tl.art in ("/:/resources/movie-fanart.jpg", None)
565565
assert tl.content == "secondary"
566566
assert tl.identifier == "com.plexapp.plugins.library"
567567
assert datetime.fromtimestamp(tl.latestEntryTime).date() == datetime.today().date()
568568
assert tl.mediaTagPrefix == "/system/bundle/media/flags/"
569569
assert tl.mediaTagVersion > 1
570-
assert tl.thumb == "/:/resources/movie.png"
570+
assert tl.thumb in ("/:/resources/movie.png", None)
571571
assert tl.title1 == "Movies"
572572
assert utils.is_int(tl.updateQueueSize, gte=0)
573573
assert tl.viewGroup == "secondary"

tests/test_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ def test_server_system_accounts(plex):
421421
assert account.defaultSubtitleLanguage == "en"
422422
assert utils.is_int(account.id, gte=0)
423423
assert len(account.key)
424-
assert len(account.name)
424+
assert "" if account.id == 0 else len(account.name)
425425
assert account.subtitleMode == 0
426426
assert account.thumb == ""
427427
assert account.accountID == account.id

0 commit comments

Comments
 (0)