quieter output by default, improved error handling

Author: Chris Putnam

binmerge

@@ -6,7 +6,18 @@
 #
 # Please report any bugs on GitHub: https://github.com/putnam/binmerge
 
-import argparse, re, os, subprocess
+import argparse, re, os, subprocess, sys
+VERBOSE = False
+
+def d(s):
+  if VERBOSE:
+    print("[DEBUG]\t%s" % s)
+
+def e(s):
+  print("[ERROR]\t%s" % s)
+
+def p(s):
+  print("[INFO]\t%s" % s)
 
 class Track:
   globalBlocksize = None
@@ -37,7 +48,7 @@ class Track:
         Track.globalBlocksize = 2048
       elif track_type in ['MODE2/2336', 'CDI/2336']:
         Track.globalBlocksize = 2336
-      print("Locked blocksize to %d" % Track.globalBlocksize)
+      d("Locked blocksize to %d" % Track.globalBlocksize)
 
 class File:
   def __init__(self, filename):
@@ -74,17 +85,17 @@ def read_cue_file(cue_path):
       next_item_offset = t.indexes[0]["file_offset"]
 
   for f in files:
-    print("-- File --")
-    print("Filename: %s" % f.filename)
-    print("Size: %d" % f.size)
-    print("Tracks:")
+    d("-- File --")
+    d("Filename: %s" % f.filename)
+    d("Size: %d" % f.size)
+    d("Tracks:")
 
     for t in f.tracks:
-      print("  -- Track --")
-      print("  Num: %d" % t.num)
-      print("  Type: %s" % t.track_type)
-      if t.sectors: print("  Sectors: %s" % t.sectors)
-      print("  Indexes: %s" % repr(t.indexes))
+      d("  -- Track --")
+      d("  Num: %d" % t.num)
+      d("  Type: %s" % t.track_type)
+      if t.sectors: d("  Sectors: %s" % t.sectors)
+      d("  Indexes: %s" % repr(t.indexes))
 
   return files
 
@@ -146,6 +157,10 @@ def gen_split_cuesheet(basename, merged_file):
 
 # Merges files together to new file `merged_filename`, in listed order.
 def merge_files(merged_filename, files):
+  if os.path.exists(merged_filename):
+    e('Target merged bin path already exists: %s' % merged_filename)
+    return False
+
   # cat is actually a bit faster, but this is multi-platform and no special-casing
   chunksize = 1024 * 1024
   with open(merged_filename, 'wb') as outfile:
@@ -161,6 +176,13 @@ def merge_files(merged_filename, files):
 # Writes each track in a File to a new file
 def split_files(new_basename, merged_file):
   with open(merged_file.filename, 'rb') as infile:
+    # Check all tracks for potential file-clobbering first before writing anything
+    for t in merged_file.tracks:
+      out_name = track_filename(new_basename, t.num, len(merged_file.tracks))
+      if os.path.exists(out_name):
+        e('Target bin path already exists: %s' % out_name)
+        return False
+
     for t in merged_file.tracks:
       chunksize = 1024 * 1024
       out_name = track_filename(new_basename, t.num, len(merged_file.tracks))
@@ -178,14 +200,19 @@ def split_files(new_basename, merged_file):
   return True
 
 def main():
-  parser = argparse.ArgumentParser(description="Using a cuesheet, merges numerous bin files into a single bin file and produces a new cuesheet with corrected offsets. Works great with Redump. Supports all block modes, but only binary track types. Should work on any python3 platform.")
-  parser.add_argument('cuefile', help='path to source cuefile with multiple referenced bin tracks')
+  parser = argparse.ArgumentParser(description="Using a cuesheet, merges numerous bin files into a single bin file and produces a new cuesheet with corrected offsets. Works great with Redump. Supports all block modes, but only binary track types.")
+  parser.add_argument('cuefile', help='path to current cue file (bin files are expected in the same dir)')
   parser.add_argument('basename', help='name (without extension) for your new bin/cue files')
-  parser.add_argument('--split', help='reverses operation, splitting merged files back to individual tracks', required=False, action="store_true")
+  parser.add_argument('--split', help='reverses operation, splitting merged files back to individual tracks', required=False, action='store_true')
   parser.add_argument('-o', dest='outdir', required=False, default=False, help='output directory. defaults to the same directory as source cue')
+  parser.add_argument('-v', dest='verbose', action='store_true', help='print more verbose messages')
   args = parser.parse_args()
 
+  if args.verbose:
+    global VERBOSE
+    VERBOSE = True
 
+  p("Opening cue: %s" % args.cuefile)
   cue_map = read_cue_file(args.cuefile)
   if args.split:
     cuesheet = gen_split_cuesheet(args.basename, cue_map[0])
@@ -197,24 +224,34 @@ def main():
     outdir = args.outdir
 
   if not os.path.exists(args.outdir):
-    print("Output dir does not exist")
+    e("Output dir does not exist")
     return False
 
-  with open(os.path.join(outdir, args.basename+'.cue'), 'w', newline='\r\n') as f:
-    f.write(cuesheet)
-  print("Wrote %s" % args.basename+'.cue')
+  new_cue_fn = os.path.join(outdir, args.basename+'.cue')
+  if os.path.exists(new_cue_fn):
+    e("Output cue file already exists. Quitting. Path: %s" % new_cue_fn)
+    return False
 
   if args.split:
-    print("Splitting files...")
+    p("Splitting files...")
     if split_files(os.path.join(outdir, args.basename), cue_map[0]):
-      print("Wrote %d bin files" % len(cue_map[0].tracks))
+      p("Wrote %d bin files" % len(cue_map[0].tracks))
     else:
-      print("Unable to split bin files")
+      e("Unable to split bin files.")
+      return False
   else:
-    print("Merging files...")
+    p("Merging %d tracks..." % len(cue_map))
     if merge_files(os.path.join(outdir, args.basename+'.bin'), cue_map):
-      print("Wrote %s" % args.basename+'.bin')
+      p("Wrote %s" % args.basename+'.bin')
     else:
-      print("Unable to merge bin files")
+      e("Unable to merge bin files.")
+      return False
+
+  with open(new_cue_fn, 'w', newline='\r\n') as f:
+    f.write(cuesheet)
+  p("Wrote new cue: %s" % new_cue_fn)
+
+  return True
 
-main()
+if not main():
+  sys.exit(1)