fix(chart): add explicit namespace to all resource templates (#107)

Helm templates were missing namespace metadata, causing resources to
deploy into the default namespace instead of the release namespace
when using helm install --namespace. Adding .Release.Namespace to
Deployment, Service, ServiceAccount, Secret, Role, and RoleBinding
ensures resources are created in the intended namespace.

Author: endoze

charts/cert-manager-webhook-dnsimple/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "v0.1.11"
 description: cert-manager webhook solver for ACME DNS01 challenge via DNSimple
 name: cert-manager-webhook-dnsimple
-version: 0.1.12
+version: 0.1.13
 home: https://github.com/puzzle/cert-manager-webhook-dnsimple
 sources:
   - https://github.com/puzzle/cert-manager-webhook-dnsimple

charts/cert-manager-webhook-dnsimple/templates/apiservice.yaml

@@ -15,5 +15,5 @@ spec:
   versionPriority: 15
   service:
     name: {{ include "dnsimple-webhook.fullname" . }}
-    namespace: {{ .Release.Namespace }}
+    namespace: {{ .Release.Namespace | quote }}
   version: v1alpha1

charts/cert-manager-webhook-dnsimple/templates/deployment.yaml

@@ -6,6 +6,7 @@ apiVersion: extensions/v1beta1
 kind: Deployment
 metadata:
   name: {{ include "dnsimple-webhook.fullname" . }}
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "dnsimple-webhook.name" . }}
     chart: {{ include "dnsimple-webhook.chart" . }}

charts/cert-manager-webhook-dnsimple/templates/rbac.yaml

@@ -2,6 +2,7 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: {{ include "dnsimple-webhook.fullname" . }}
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "dnsimple-webhook.name" . }}
     chart: {{ include "dnsimple-webhook.chart" . }}
@@ -29,7 +30,7 @@ subjects:
   - apiGroup: ""
     kind: ServiceAccount
     name: {{ include "dnsimple-webhook.fullname" . }}
-    namespace: {{ .Release.Namespace }}
+    namespace: {{ .Release.Namespace | quote }}
 ---
 # apiserver gets the auth-delegator role to delegate auth decisions to
 # the core apiserver
@@ -50,7 +51,7 @@ subjects:
   - apiGroup: ""
     kind: ServiceAccount
     name: {{ include "dnsimple-webhook.fullname" . }}
-    namespace: {{ .Release.Namespace }}
+    namespace: {{ .Release.Namespace | quote }}
 ---
 # Grant cert-manager permission to validate using our apiserver
 apiVersion: rbac.authorization.k8s.io/v1

charts/cert-manager-webhook-dnsimple/templates/secret.yaml

@@ -3,6 +3,7 @@ apiVersion: v1
 kind: Secret
 metadata:
   name: {{ include "dnsimple-webhook.tokenSecretName" . }}
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "dnsimple-webhook.name" . }}
     chart: {{ include "dnsimple-webhook.chart" . }}
@@ -17,6 +18,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   name: {{ include "dnsimple-webhook.fullname" . }}:secret-reader
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "dnsimple-webhook.name" . }}
     chart: {{ include "dnsimple-webhook.chart" . }}
@@ -32,6 +34,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   name: {{ include "dnsimple-webhook.fullname" . }}:secret-reader
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "dnsimple-webhook.name" . }}
     chart: {{ include "dnsimple-webhook.chart" . }}
@@ -41,7 +44,7 @@ subjects:
  - apiGroup: ""
    kind: ServiceAccount
    name: {{ include "dnsimple-webhook.fullname" . }}
-   namespace: {{ .Release.Namespace }}
+   namespace: {{ .Release.Namespace | quote }}
 roleRef:
   kind: Role
   name: {{ include "dnsimple-webhook.fullname" . }}:secret-reader

charts/cert-manager-webhook-dnsimple/templates/service.yaml

@@ -2,6 +2,7 @@ apiVersion: v1
 kind: Service
 metadata:
   name: {{ include "dnsimple-webhook.fullname" . }}
+  namespace: {{ .Release.Namespace | quote }}
   labels:
     app: {{ include "dnsimple-webhook.name" . }}
     chart: {{ include "dnsimple-webhook.chart" . }}