Skip to content

Commit 6b7cebc

Browse files
RetGalRetGal
authored
Lint (#78)
* Add lint action
1 parent 6308ec5 commit 6b7cebc

File tree

12 files changed

+161
-137
lines changed

12 files changed

+161
-137
lines changed

‎.github/workflows/lint.yml‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
name: Lint
2+
3+
on:
4+
pull_request:
5+
branches:
6+
- main
7+
8+
permissions:
9+
checks: write
10+
contents: write
11+
12+
jobs:
13+
run-linters:
14+
name: Run linters
15+
runs-on: ubuntu-latest
16+
17+
steps:
18+
- name: Check out Git repository
19+
uses: actions/checkout@v4
20+
21+
- name: Install Go
22+
run: sudo apt-get install -y golang-go
23+
24+
- name: Run linters
25+
uses: wearerequired/lint-action@v2
26+
with:
27+
gofmt: true
28+
auto_fix: true
29+
gofmt_args: "-w -s"

‎README.md‎

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,44 @@
1-
# daggerverse Helm Module
1+
# Daggerverse Helm Module
22

33
[Dagger](https://dagger.io/) module for [daggerverse](https://daggerverse.dev/) providing [Helm](https://helm.sh/) functionality.
44

55
The Dagger module is located in the [helm](./helm/) directory.
66

7-
## usage
7+
## Usage
88

99
Basic usage guide.
1010

1111
The [helm](./helm/) directory contains a [daggerverse](https://daggerverse.dev/) [Dagger](https://dagger.io/) module.
1212

13-
Check the official Dagger Module documentation: https://docs.dagger.io/zenith/
13+
Check the official Dagger Module documentation: https://docs.dagger.io/api/module-structure
1414

1515
The [Dagger CLI](https://docs.dagger.io/cli) is needed.
1616

17-
### functions
17+
### Functions
1818

1919
List all functions of the module. This command is provided by the [Dagger CLI](https://docs.dagger.io/cli).
2020

2121
```bash
2222
dagger functions -m ./helm/
2323
```
2424

25-
The helm module is referenced locally.
26-
27-
See the module [readme](./helm/README.md) or the method comments for more details.
28-
29-
## development
25+
## Development
3026

3127
Basic development guide.
3228

33-
### setup Dagger module
34-
35-
Setup the Dagger module.
36-
37-
Create the directory for the module and initialize it.
29+
### Setup/update Dagger module
3830

3931
```bash
40-
mkdir helm/
41-
cd helm/
42-
43-
# initialize Dagger module
44-
dagger init
45-
dagger develop --sdk go --source helm
32+
dagger -m ./helm/ develop
4633
```
4734

35+
## Contributors
36+
37+
Please add `gofmt -s -w .` to your `.git/hooks/pre-commit` hook.
38+
4839
## To Do
4940

5041
- [ ] Add more tools
5142
- [ ] Add cache mounts
5243
- [ ] Add environment variables
5344
- [ ] Add more examples
54-
- [ ] Add tests

‎ci/main.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type Ci struct{}
1515
// Build helm image used in the helm module.
1616
func (m *Ci) Build(
1717
ctx context.Context,
18-
) (*dagger.Container) {
18+
) *dagger.Container {
1919

2020
// location of source directory
2121
src := dag.CurrentModule().Source().Directory(".")

‎helm/dagger.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "helm",
3-
"engineVersion": "v0.16.2",
3+
"engineVersion": "v0.18.5",
44
"sdk": {
55
"source": "go"
66
}

‎helm/examples/go/main.go‎

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Go examples for the Helm module.
22
//
3-
// This module defines the examples for the Daggerverse.
3+
// This module defines the examples for the Daggerverse.
44

55
package main
66

@@ -11,7 +11,6 @@ import (
1111

1212
type Examples struct{}
1313

14-
1514
// Example on how to call the PackagePush method.
1615
// Packages and pushes a Helm chart to a specified OCI-compatible registry with authentication.
1716
//
@@ -31,8 +30,8 @@ func (h *Examples) HelmPackagepush(
3130
password *dagger.Secret,
3231
) (bool, error) {
3332
return dag.
34-
Helm().
35-
PackagePush(ctx, directory, registry, repository, username, password)
33+
Helm().
34+
PackagePush(ctx, directory, registry, repository, username, password)
3635
}
3736

3837
// Example on how to call the Lint method.
@@ -46,13 +45,13 @@ func (h *Examples) HelmLint(
4645
ctx context.Context,
4746
// directory that contains the Helm Chart, e.g. "./helm/examples/testdata/mychart/"
4847
directory *dagger.Directory,
49-
// Helm lint arguments
50-
// +optional
48+
// Helm lint arguments
49+
// +optional
5150
args []string,
5251
) (string, error) {
5352
return dag.
54-
Helm().
55-
Lint(ctx, directory)
53+
Helm().
54+
Lint(ctx, directory)
5655
}
5756

5857
// Example on how to call the Test method.
@@ -70,12 +69,12 @@ func (h *Examples) HelmTest(
7069
args []string,
7170
) (string, error) {
7271
return dag.
73-
Helm().
74-
Test(ctx, directory, args)
72+
Helm().
73+
Test(ctx, directory, args)
7574
}
7675

7776
// Example on how to call the Version method.
78-
//
77+
//
7978
// Get and display the version of the Helm Chart located inside the directory referenced by the directory parameter.
8079
//
8180
// Return: The Helm Chart version as string.
@@ -86,6 +85,6 @@ func (m *Examples) HelmVersion(
8685
chart *dagger.Directory,
8786
) (string, error) {
8887
return dag.
89-
Helm().
90-
Version(ctx, chart)
88+
Helm().
89+
Version(ctx, chart)
9190
}

‎helm/go.mod‎

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@ module dagger/helm
33
go 1.23.2
44

55
require (
6-
github.com/99designs/gqlgen v0.17.66
6+
github.com/99designs/gqlgen v0.17.70
77
github.com/Khan/genqlient v0.8.0
8-
github.com/vektah/gqlparser/v2 v2.5.22
9-
go.opentelemetry.io/otel v1.32.0
8+
github.com/vektah/gqlparser/v2 v2.5.23
9+
go.opentelemetry.io/otel v1.34.0
1010
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.8.0
1111
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.8.0
1212
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.32.0
1313
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.32.0
1414
go.opentelemetry.io/otel/log v0.8.0
15-
go.opentelemetry.io/otel/sdk v1.32.0
15+
go.opentelemetry.io/otel/sdk v1.34.0
1616
go.opentelemetry.io/otel/sdk/log v0.8.0
17-
go.opentelemetry.io/otel/trace v1.32.0
17+
go.opentelemetry.io/otel/trace v1.34.0
1818
go.opentelemetry.io/proto/otlp v1.3.1
19-
golang.org/x/sync v0.11.0
20-
google.golang.org/grpc v1.70.0
19+
golang.org/x/sync v0.12.0
20+
google.golang.org/grpc v1.71.0
2121
)
2222

2323
require (
@@ -27,17 +27,18 @@ require (
2727
github.com/google/uuid v1.6.0 // indirect
2828
github.com/grpc-ecosystem/grpc-gateway/v2 v2.23.0 // indirect
2929
github.com/sosodev/duration v1.3.1 // indirect
30+
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
3031
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.32.0
3132
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.32.0
3233
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.32.0 // indirect
33-
go.opentelemetry.io/otel/metric v1.32.0
34-
go.opentelemetry.io/otel/sdk/metric v1.32.0
35-
golang.org/x/net v0.35.0 // indirect
36-
golang.org/x/sys v0.30.0 // indirect
37-
golang.org/x/text v0.22.0 // indirect
38-
google.golang.org/genproto/googleapis/api v0.0.0-20241202173237-19429a94021a // indirect
39-
google.golang.org/genproto/googleapis/rpc v0.0.0-20241202173237-19429a94021a // indirect
40-
google.golang.org/protobuf v1.36.5 // indirect
34+
go.opentelemetry.io/otel/metric v1.34.0
35+
go.opentelemetry.io/otel/sdk/metric v1.34.0
36+
golang.org/x/net v0.38.0 // indirect
37+
golang.org/x/sys v0.31.0 // indirect
38+
golang.org/x/text v0.23.0 // indirect
39+
google.golang.org/genproto/googleapis/api v0.0.0-20250106144421-5f5ef82da422 // indirect
40+
google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f // indirect
41+
google.golang.org/protobuf v1.36.6 // indirect
4142
)
4243

4344
replace go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc => go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.8.0

‎helm/go.sum‎

Lines changed: 32 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
github.com/99designs/gqlgen v0.17.66 h1:2/SRc+h3115fCOZeTtsqrB5R5gTGm+8qCAwcrZa+CXA=
2-
github.com/99designs/gqlgen v0.17.66/go.mod h1:gucrb5jK5pgCKzAGuOMMVU9C8PnReecHEHd2UxLQwCg=
1+
github.com/99designs/gqlgen v0.17.70 h1:xgLIgQuG+Q2L/AE9cW595CT7xCWCe/bpPIFGSfsGSGs=
2+
github.com/99designs/gqlgen v0.17.70/go.mod h1:fvCiqQAu2VLhKXez2xFvLmE47QgAPf/KTPN5XQ4rsHQ=
33
github.com/Khan/genqlient v0.8.0 h1:Hd1a+E1CQHYbMEKakIkvBH3zW0PWEeiX6Hp1i2kP2WE=
44
github.com/Khan/genqlient v0.8.0/go.mod h1:hn70SpYjWteRGvxTwo0kfaqg4wxvndECGkfa1fdDdYI=
55
github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883 h1:bvNMNQO63//z+xNgfBlViaCIJKLlCJ6/fmUseuG0wVQ=
@@ -29,10 +29,12 @@ github.com/sosodev/duration v1.3.1 h1:qtHBDMQ6lvMQsL15g4aopM4HEfOaYuhWBw3NPTtlqq
2929
github.com/sosodev/duration v1.3.1/go.mod h1:RQIBBX0+fMLc/D9+Jb/fwvVmo0eZvDDEERAikUR6SDg=
3030
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
3131
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
32-
github.com/vektah/gqlparser/v2 v2.5.22 h1:yaaeJ0fu+nv1vUMW0Hl+aS1eiv1vMfapBNjpffAda1I=
33-
github.com/vektah/gqlparser/v2 v2.5.22/go.mod h1:xMl+ta8a5M1Yo1A1Iwt/k7gSpscwSnHZdw7tfhEGfTM=
34-
go.opentelemetry.io/otel v1.32.0 h1:WnBN+Xjcteh0zdk01SVqV55d/m62NJLJdIyb4y/WO5U=
35-
go.opentelemetry.io/otel v1.32.0/go.mod h1:00DCVSB0RQcnzlwyTfqtxSm+DRr9hpYrHjNGiBHVQIg=
32+
github.com/vektah/gqlparser/v2 v2.5.23 h1:PurJ9wpgEVB7tty1seRUwkIDa/QH5RzkzraiKIjKLfA=
33+
github.com/vektah/gqlparser/v2 v2.5.23/go.mod h1:D1/VCZtV3LPnQrcPBeR/q5jkSQIPti0uYCP/RI0gIeo=
34+
go.opentelemetry.io/auto/sdk v1.1.0 h1:cH53jehLUN6UFLY71z+NDOiNJqDdPRaXzTel0sJySYA=
35+
go.opentelemetry.io/auto/sdk v1.1.0/go.mod h1:3wSPjt5PWp2RhlCcmmOial7AvC4DQqZb7a7wCow3W8A=
36+
go.opentelemetry.io/otel v1.34.0 h1:zRLXxLCgL1WyKsPVrgbSdMN4c0FMkDAskSTQP+0hdUY=
37+
go.opentelemetry.io/otel v1.34.0/go.mod h1:OWFPOQ+h4G8xpyjgqo4SxJYdDQ/qmRH+wivy7zzx9oI=
3638
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.8.0 h1:WzNab7hOOLzdDF/EoWCt4glhrbMPVMOO5JYTmpz36Ls=
3739
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.8.0/go.mod h1:hKvJwTzJdp90Vh7p6q/9PAOd55dI6WA6sWj62a/JvSs=
3840
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.8.0 h1:S+LdBGiQXtJdowoJoQPEtI52syEP/JYBUpjO49EQhV8=
@@ -49,35 +51,35 @@ go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.32.0 h1:cMyu9
4951
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.32.0/go.mod h1:6Am3rn7P9TVVeXYG+wtcGE7IE1tsQ+bP3AuWcKt/gOI=
5052
go.opentelemetry.io/otel/log v0.8.0 h1:egZ8vV5atrUWUbnSsHn6vB8R21G2wrKqNiDt3iWertk=
5153
go.opentelemetry.io/otel/log v0.8.0/go.mod h1:M9qvDdUTRCopJcGRKg57+JSQ9LgLBrwwfC32epk5NX8=
52-
go.opentelemetry.io/otel/metric v1.32.0 h1:xV2umtmNcThh2/a/aCP+h64Xx5wsj8qqnkYZktzNa0M=
53-
go.opentelemetry.io/otel/metric v1.32.0/go.mod h1:jH7CIbbK6SH2V2wE16W05BHCtIDzauciCRLoc/SyMv8=
54-
go.opentelemetry.io/otel/sdk v1.32.0 h1:RNxepc9vK59A8XsgZQouW8ue8Gkb4jpWtJm9ge5lEG4=
55-
go.opentelemetry.io/otel/sdk v1.32.0/go.mod h1:LqgegDBjKMmb2GC6/PrTnteJG39I8/vJCAP9LlJXEjU=
54+
go.opentelemetry.io/otel/metric v1.34.0 h1:+eTR3U0MyfWjRDhmFMxe2SsW64QrZ84AOhvqS7Y+PoQ=
55+
go.opentelemetry.io/otel/metric v1.34.0/go.mod h1:CEDrp0fy2D0MvkXE+dPV7cMi8tWZwX3dmaIhwPOaqHE=
56+
go.opentelemetry.io/otel/sdk v1.34.0 h1:95zS4k/2GOy069d321O8jWgYsW3MzVV+KuSPKp7Wr1A=
57+
go.opentelemetry.io/otel/sdk v1.34.0/go.mod h1:0e/pNiaMAqaykJGKbi+tSjWfNNHMTxoC9qANsCzbyxU=
5658
go.opentelemetry.io/otel/sdk/log v0.8.0 h1:zg7GUYXqxk1jnGF/dTdLPrK06xJdrXgqgFLnI4Crxvs=
5759
go.opentelemetry.io/otel/sdk/log v0.8.0/go.mod h1:50iXr0UVwQrYS45KbruFrEt4LvAdCaWWgIrsN3ZQggo=
58-
go.opentelemetry.io/otel/sdk/metric v1.32.0 h1:rZvFnvmvawYb0alrYkjraqJq0Z4ZUJAiyYCU9snn1CU=
59-
go.opentelemetry.io/otel/sdk/metric v1.32.0/go.mod h1:PWeZlq0zt9YkYAp3gjKZ0eicRYvOh1Gd+X99x6GHpCQ=
60-
go.opentelemetry.io/otel/trace v1.32.0 h1:WIC9mYrXf8TmY/EXuULKc8hR17vE+Hjv2cssQDe03fM=
61-
go.opentelemetry.io/otel/trace v1.32.0/go.mod h1:+i4rkvCraA+tG6AzwloGaCtkx53Fa+L+V8e9a7YvhT8=
60+
go.opentelemetry.io/otel/sdk/metric v1.34.0 h1:5CeK9ujjbFVL5c1PhLuStg1wxA7vQv7ce1EK0Gyvahk=
61+
go.opentelemetry.io/otel/sdk/metric v1.34.0/go.mod h1:jQ/r8Ze28zRKoNRdkjCZxfs6YvBTG1+YIqyFVFYec5w=
62+
go.opentelemetry.io/otel/trace v1.34.0 h1:+ouXS2V8Rd4hp4580a8q23bg0azF2nI8cqLYnC8mh/k=
63+
go.opentelemetry.io/otel/trace v1.34.0/go.mod h1:Svm7lSjQD7kG7KJ/MUHPVXSDGz2OX4h0M2jHBhmSfRE=
6264
go.opentelemetry.io/proto/otlp v1.3.1 h1:TrMUixzpM0yuc/znrFTP9MMRh8trP93mkCiDVeXrui0=
6365
go.opentelemetry.io/proto/otlp v1.3.1/go.mod h1:0X1WI4de4ZsLrrJNLAQbFeLCm3T7yBkR0XqQ7niQU+8=
6466
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
6567
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
66-
golang.org/x/net v0.35.0 h1:T5GQRQb2y08kTAByq9L4/bz8cipCdA8FbRTXewonqY8=
67-
golang.org/x/net v0.35.0/go.mod h1:EglIi67kWsHKlRzzVMUD93VMSWGFOMSZgxFjparz1Qk=
68-
golang.org/x/sync v0.11.0 h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=
69-
golang.org/x/sync v0.11.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
70-
golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
71-
golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
72-
golang.org/x/text v0.22.0 h1:bofq7m3/HAFvbF51jz3Q9wLg3jkvSPuiZu/pD1XwgtM=
73-
golang.org/x/text v0.22.0/go.mod h1:YRoo4H8PVmsu+E3Ou7cqLVH8oXWIHVoX0jqUWALQhfY=
74-
google.golang.org/genproto/googleapis/api v0.0.0-20241202173237-19429a94021a h1:OAiGFfOiA0v9MRYsSidp3ubZaBnteRUyn3xB2ZQ5G/E=
75-
google.golang.org/genproto/googleapis/api v0.0.0-20241202173237-19429a94021a/go.mod h1:jehYqy3+AhJU9ve55aNOaSml7wUXjF9x6z2LcCfpAhY=
76-
google.golang.org/genproto/googleapis/rpc v0.0.0-20241202173237-19429a94021a h1:hgh8P4EuoxpsuKMXX/To36nOFD7vixReXgn8lPGnt+o=
77-
google.golang.org/genproto/googleapis/rpc v0.0.0-20241202173237-19429a94021a/go.mod h1:5uTbfoYQed2U9p3KIj2/Zzm02PYhndfdmML0qC3q3FU=
78-
google.golang.org/grpc v1.70.0 h1:pWFv03aZoHzlRKHWicjsZytKAiYCtNS0dHbXnIdq7jQ=
79-
google.golang.org/grpc v1.70.0/go.mod h1:ofIJqVKDXx/JiXrwr2IG4/zwdH9txy3IlF40RmcJSQw=
80-
google.golang.org/protobuf v1.36.5 h1:tPhr+woSbjfYvY6/GPufUoYizxw1cF/yFoxJ2fmpwlM=
81-
google.golang.org/protobuf v1.36.5/go.mod h1:9fA7Ob0pmnwhb644+1+CVWFRbNajQ6iRojtC/QF5bRE=
68+
golang.org/x/net v0.38.0 h1:vRMAPTMaeGqVhG5QyLJHqNDwecKTomGeqbnfZyKlBI8=
69+
golang.org/x/net v0.38.0/go.mod h1:ivrbrMbzFq5J41QOQh0siUuly180yBYtLp+CKbEaFx8=
70+
golang.org/x/sync v0.12.0 h1:MHc5BpPuC30uJk597Ri8TV3CNZcTLu6B6z4lJy+g6Jw=
71+
golang.org/x/sync v0.12.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
72+
golang.org/x/sys v0.31.0 h1:ioabZlmFYtWhL+TRYpcnNlLwhyxaM9kWTDEmfnprqik=
73+
golang.org/x/sys v0.31.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
74+
golang.org/x/text v0.23.0 h1:D71I7dUrlY+VX0gQShAThNGHFxZ13dGLBHQLVl1mJlY=
75+
golang.org/x/text v0.23.0/go.mod h1:/BLNzu4aZCJ1+kcD0DNRotWKage4q2rGVAg4o22unh4=
76+
google.golang.org/genproto/googleapis/api v0.0.0-20250106144421-5f5ef82da422 h1:GVIKPyP/kLIyVOgOnTwFOrvQaQUzOzGMCxgFUOEmm24=
77+
google.golang.org/genproto/googleapis/api v0.0.0-20250106144421-5f5ef82da422/go.mod h1:b6h1vNKhxaSoEI+5jc3PJUCustfli/mRab7295pY7rw=
78+
google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f h1:OxYkA3wjPsZyBylwymxSHa7ViiW1Sml4ToBrncvFehI=
79+
google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f/go.mod h1:+2Yz8+CLJbIfL9z73EW45avw8Lmge3xVElCP9zEKi50=
80+
google.golang.org/grpc v1.71.0 h1:kF77BGdPTQ4/JZWMlb9VpJ5pa25aqvVqogsxNHHdeBg=
81+
google.golang.org/grpc v1.71.0/go.mod h1:H0GRtasmQOh9LkFoCPDu3ZrwUtD1YGE+b2vYBYd/8Ec=
82+
google.golang.org/protobuf v1.36.6 h1:z1NpPI8ku2WgiWnf+t9wTPsn6eP1L7ksHUlkfLvd9xY=
83+
google.golang.org/protobuf v1.36.6/go.mod h1:jduwjTPXsFjZGTmRluh+L6NjiWu7pchiJ2/5YcXBHnY=
8284
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
8385
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

‎helm/main.go‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func (p PushOpts) getProtocol() string {
3535
}
3636

3737
func (p PushOpts) getRepoFqdn() string {
38-
return fmt.Sprintf("%s://%s/%s", p.getProtocol(), p.Registry, p.Repository)
38+
return fmt.Sprintf("%s://%s/%s", p.getProtocol(), p.Registry, p.Repository)
3939
}
4040

4141
func (p PushOpts) getChartFqdn(name string) string {
@@ -101,7 +101,7 @@ func (h *Helm) PackagePush(
101101
// use a non-OCI (legacy) Helm repository
102102
// +optional
103103
// +default=false
104-
useNonOciHelmRepo bool, // Dev note: We are forced to use default=false due to https://github.com/dagger/dagger/issues/8810
104+
useNonOciHelmRepo bool, // Dev note: We are forced to use default=false due to https://github.com/dagger/dagger/issues/8810
105105
) (bool, error) {
106106
opts := PushOpts{
107107
Registry: registry,
@@ -269,7 +269,7 @@ func (h *Helm) doesChartExistOnRepo(
269269
if exc == "0" {
270270
//Chart exists
271271
return true, nil
272-
}
272+
}
273273

274274
return false, nil
275275
}
@@ -278,11 +278,11 @@ func (h *Helm) doesChartExistOnRepo(
278278
// Do a GET of the chart but with response headers only so we do not download the chart
279279
curlCmd := []string{
280280
`curl --variable %REGISTRY_USERNAME`,
281-
`--variable %REGISTRY_PASSWORD`,
282-
`--expand-user "{{REGISTRY_USERNAME}}:{{REGISTRY_PASSWORD}}"`,
283-
opts.getChartFqdn(pkgFile),
284-
`--output /dev/null`,
285-
`--silent -Iw '%{http_code}'`,
281+
`--variable %REGISTRY_PASSWORD`,
282+
`--expand-user "{{REGISTRY_USERNAME}}:{{REGISTRY_PASSWORD}}"`,
283+
opts.getChartFqdn(pkgFile),
284+
`--output /dev/null`,
285+
`--silent -Iw '%{http_code}'`,
286286
}
287287

288288
httpCode, err := c.

‎tests/dagger.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "go",
3-
"engineVersion": "v0.16.2",
3+
"engineVersion": "v0.18.5",
44
"sdk": {
55
"source": "go"
66
},

0 commit comments

Comments
 (0)