review

Author: cwhanse

docs/sphinx/source/whatsnew/v0.11.2.rst

@@ -24,10 +24,10 @@ Bug fixes
 Documentation
 ~~~~~~~~~~~~~
 * Edited docstrings for :py:func:`~pvlib.pvsystem.dc_ohms_from_percent` and
-  :py:func:`~pvlib.pvsystem.dc_ohmic_loss` for clarity. (:issue:`1601`, :pull:`2229`)
-* Clarified that :py:meth:`~pvlib.pvsystem.PVSystem.get_irradiance` and
-  :py:meth:`~pvlib.pvsystem.Array.get_irradiance` do not accept tuple of float
-  as input. (:pull:`2227`)
+  :py:func:`~pvlib.pvsystem.dc_ohmic_losses` for clarity. (:issue:`1601`, :pull:`2229`)
+* Corrected a bug in :py:meth:`~pvlib.pvsystem.PVSystem.get_irradiance` and
+  :py:meth:`~pvlib.pvsystem.Array.get_irradiance` when `solar_zenith` is passed
+  float as input. (:issue:`1338`, :pull:`2227`)
 * Added a new citation style guide (:ref:`references`) to the contributing
   page. (:issue:`2202`, :pull:`2226`)
 * Updated :py:func:`~pvlib.irradiance.reindl` to include definitions of terms

pvlib/pvsystem.py

@@ -323,13 +323,13 @@ def get_irradiance(self, solar_zenith, solar_azimuth, dni, ghi, dhi,
             Solar zenith angle.
         solar_azimuth : float or Series
             Solar azimuth angle.
-        dni : float, Series, or tuple of Series
+        dni : float, Series, or tuple of float or Series
             Direct Normal Irradiance. [W/m2]
-        ghi : float, Series, or tuple of Series
+        ghi : float, Series, or tuple of float or Series
             Global horizontal irradiance. [W/m2]
-        dhi : float, Series, or tuple of Series
+        dhi : float, Series, or tuple of float or Series
             Diffuse horizontal irradiance. [W/m2]
-        dni_extra : float, Series or tuple of Series, optional
+        dni_extra : float, Series or tuple of float or Series, optional
             Extraterrestrial direct normal irradiance. [W/m2]
         airmass : float or Series, optional
             Airmass. [unitless]
@@ -364,7 +364,7 @@ def get_irradiance(self, solar_zenith, solar_azimuth, dni, ghi, dhi,
 
         See also
         --------
-        :py:func:`pvlib.irradiance.get_total_irradiance`
+        pvlib.irradiance.get_total_irradiance
         """
         dni = self._validate_per_array(dni, system_wide=True)
         ghi = self._validate_per_array(ghi, system_wide=True)