Skip to content

Commit 24f82df

Browse files
RDaxinicwhanse
andauthored
Apply suggestions from code review
Thanks for the review Co-authored-by: Cliff Hansen <[email protected]>
1 parent 4b78046 commit 24f82df

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

docs/sphinx/source/whatsnew/v0.11.2.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ Documentation
1616
~~~~~~~~~~~~~
1717
* Edited docstrings for :py:func:`~pvlib.pvsystem.dc_ohms_from_percent` and
1818
:py:func:`~pvlib.pvsystem.dc_ohmic_losses` for clarity. (:issue:`1601`, :pull:`2229`)
19-
* Updated :py:func:`~pvlib.irradiance.reindle` to include equation variable
20-
definitions and a new "notes" section (:issue:`2183`, :pull:`2193`)
19+
* Updated :py:func:`~pvlib.irradiance.reindl` to include definitions of terms
20+
and a new "notes" section (:issue:`2183`, :pull:`2193`)
2121

2222
Testing
2323
~~~~~~~

pvlib/irradiance.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,7 @@ def reindl(surface_tilt, surface_azimuth, dhi, dni, ghi, dni_extra,
875875
the Reindl (1990) model.
876876
877877
The Reindl (1990) model [1]_ [2]_ determines the diffuse irradiance from
878-
the sky (ground reflected irradiance is not included in this algorithm) on
878+
the sky on
879879
a tilted surface using the surface tilt angle, surface azimuth angle,
880880
diffuse horizontal irradiance, direct normal irradiance, global
881881
horizontal irradiance, extraterrestrial normal irradiance, sun zenith
@@ -933,11 +933,11 @@ def reindl(surface_tilt, surface_azimuth, dhi, dni, ghi, dni_extra,
933933
and global horizontal irradiances, respectively. :math:`A` is the
934934
anisotropy index, which is the ratio of the direct normal irradiance to the
935935
extraterrestrial irradiation, :math:`R_b` is the projection ratio, which is
936-
defined as the ratio of the cosine of the angle of incidence (AOI) to the
936+
the ratio of the cosine of the angle of incidence (AOI) to the
937937
cosine of the zenith angle, and :math:`\theta_T` is the tilt angle of the
938938
array.
939939
940-
The ``poa_sky_diffuse`` calculation is generated from Loutzenhiser et al.
940+
Implementation is based on Loutzenhiser et al.
941941
(2007) [3]_, Equation 8. The beam and ground reflectance portion of the
942942
equation have been removed, therefore the model described here generates
943943
ONLY the diffuse radiation from the sky and circumsolar, so the form of the

0 commit comments

Comments
 (0)