implement modelchain tests

Author: wholmgren

pvlib/modelchain.py

@@ -75,7 +75,7 @@ def orientation_strategy(self, strategy):
             self.system.surface_azimuth = 180
             self.system.surface_tilt = self.location.latitude
         elif strategy == 'flat':
-            self.system.surface_azimuth = 0
+            self.system.surface_azimuth = 180
             self.system.surface_tilt = 0
         else:
             raise ValueError('invalid orientation strategy. strategy must ' +
@@ -84,13 +84,13 @@ def orientation_strategy(self, strategy):
         self._orientation_strategy = strategy
 
 
-    def run_model(self, times=None, irradiance=None, weather=None):
+    def run_model(self, times, irradiance=None, weather=None):
         """
         Run the model.
         
         Parameters
         ----------
-        times : None or DatetimeIndex
+        times : DatetimeIndex
         irradiance : None or DataFrame
             If None, calculates clear sky data.
             Columns must be 'dni', 'ghi', 'dhi'

pvlib/test/test_modelchain.py

@@ -1,24 +1,97 @@
+import numpy as np
+import pandas as pd
 
+from pvlib import modelchain, pvsystem
+from pvlib.modelchain import ModelChain
+from pvlib.pvsystem import PVSystem
+from pvlib.location import Location
 
-from pvlib import modelchain
+from pandas.util.testing import assert_series_equal, assert_frame_equal
+from nose.tools import with_setup
+
+# should store this test data locally, but for now...
+sam_data = {}
+def retrieve_sam_network():
+    sam_data['cecmod'] = pvsystem.retrieve_sam('cecmod')
+    sam_data['sandiamod'] = pvsystem.retrieve_sam('sandiamod')
+    sam_data['cecinverter'] = pvsystem.retrieve_sam('cecinverter')
+
+
+def mc_setup():
+    # limit network usage
+    try:
+        modules = sam_data['sandiamod']
+    except KeyError:
+        retrieve_sam_network()
+        modules = sam_data['sandiamod']
+
+    module = modules.Canadian_Solar_CS5P_220M___2009_.copy()
+    inverters = sam_data['cecinverter']
+    inverter = inverters['ABB__MICRO_0_25_I_OUTD_US_208_208V__CEC_2014_'].copy()
+
+    system = PVSystem(module_parameters=module,
+                      inverter_parameters=inverter)
+
+    location = Location(32.2, -111, altitude=700)
+    
+    return system, location
 
 
 def test_ModelChain_creation():
-    raise Exception('test me')
+    system, location = mc_setup()
+    mc = ModelChain(system, location)
 
 
 def test_orientation_strategy():
-    # test for None, 'None', 'south_at_latitude_tilt', 'flat', ValueError
-    raise Exception('test me')
+    strategies = {None: (0, 180), 'None': (0, 180),
+                  'south_at_latitude_tilt': (32.2, 180),
+                  'flat': (0, 180)}
+    
+    for strategy, expected in strategies.items():
+        yield run_orientation_strategy, strategy, expected
+
+
+def run_orientation_strategy(strategy, expected):
+    system = PVSystem()
+    location = Location(32.2, -111, altitude=700)
+
+    mc = ModelChain(system, location, orientation_strategy=strategy)
+    
+    assert system.surface_tilt == expected[0]
+    assert system.surface_azimuth == expected[1]
 
 
 def test_run_model():
-    raise Exception('test me')
+    system, location = mc_setup()
+    mc = ModelChain(system, location)
+    times = pd.date_range('20160101 1200-0700', periods=2, freq='6H')
+    dc, ac = mc.run_model(times)
+    
+    expected = pd.Series(np.array([  1.82033564e+02,  -2.00000000e-02]),
+                         index=times)
+    assert_series_equal(ac, expected)
 
 
 def test_run_model_with_irradiance():
-    raise Exception('test me')
+    system, location = mc_setup()
+    mc = ModelChain(system, location)
+    times = pd.date_range('20160101 1200-0700', periods=2, freq='6H')
+    irradiance = pd.DataFrame({'dni':900, 'ghi':600, 'dhi':150},
+                              index=times)
+    dc, ac = mc.run_model(times, irradiance=irradiance)
+
+    expected = pd.Series(np.array([  1.90054749e+02,  -2.00000000e-02]),
+                         index=times)
+    assert_series_equal(ac, expected)
 
 
 def test_run_model_with_weather():
-    raise Exception('test me')
+    system, location = mc_setup()
+    mc = ModelChain(system, location)
+    times = pd.date_range('20160101 1200-0700', periods=2, freq='6H')
+    weather = pd.DataFrame({'wind_speed':5, 'temp_air':10}, index=times)
+    dc, ac = mc.run_model(times, weather=weather)
+    
+    expected = pd.Series(np.array([  1.99952400e+02,  -2.00000000e-02]),
+                         index=times)
+    assert_series_equal(ac, expected)

pvlib/test/test_pvsystem.py

@@ -1,6 +1,3 @@
-import logging
-pvl_logger = logging.getLogger('pvlib')
-
 import inspect
 import os
 import datetime