Remove ecmwf_macc functions (#1654)

* Remove ecmwf_macc functions

* Add whatsnew entry

* Update v0.9.5.rst

* Add whatsnew to 0.9.6

* Update docs/sphinx/source/whatsnew/v0.9.6.rst

Co-authored-by: Kevin Anderson <[email protected]>

* Remove macc functions from reference/iotools.rst

* Update v0.9.6.rst

* Apply suggestions from code review

---------

Co-authored-by: Kevin Anderson <[email protected]>

Author: AdamRJensen

docs/sphinx/source/reference/iotools.rst

@@ -20,8 +20,6 @@ of sources and file formats relevant to solar energy modeling.
    iotools.read_surfrad
    iotools.read_midc
    iotools.read_midc_raw_data_from_nrel
-   iotools.read_ecmwf_macc
-   iotools.get_ecmwf_macc
    iotools.read_crn
    iotools.read_solrad
    iotools.get_psm3

docs/sphinx/source/user_guide/clearsky.rst

@@ -377,7 +377,8 @@ derived from surface relative humidity using functions such as
 :py:func:`pvlib.atmosphere.gueymard94_pw`.
 Numerous gridded products from satellites, weather models, and climate models
 contain one or both of aerosols and precipitable water. Consider data
-from the `ECMWF <https://software.ecmwf.int/wiki/display/WEBAPI/Access+ECMWF+Public+Datasets>`_
+from the `ECMWF ERA5 <https://www.ecmwf.int/en/forecasts/dataset/ecmwf-reanalysis-v5>`_,
+`NASA MERRA-2 <https://gmao.gsfc.nasa.gov/reanalysis/MERRA-2/>`_,
 and `SoDa <http://www.soda-pro.com/web-services/radiation/cams-mcclear>`_.
 
 Aerosol optical depth (AOD) is a function of wavelength, and the Simplified

docs/sphinx/source/whatsnew/v0.9.6.rst

@@ -15,6 +15,11 @@ Breaking Changes
 
 Deprecations
 ~~~~~~~~~~~~
+* Removed the ``get_ecmwf_macc`` and ``read_ecmwf_macc`` iotools functions as the
+  MACC dataset has been `removed by ECMWF <https://confluence.ecmwf.int/display/DAC/Decommissioning+of+ECMWF+Public+Datasets+Service>`_
+  (data period 2003-2012). Instead, ECMWF recommends to use CAMS global
+  reanalysis (EAC4) from the Atmosphere Data Store (ADS). See also :py:func:`pvlib.iotools.get_cams`.
+  (:issue:`1691`, :pull:`1654`)
 
 * The ``recolumn`` parameter in :py:func:`pvlib.iotools.read_tmy3`, which maps
   TMY3 column names to nonstandard alternatives, is now deprecated.

pvlib/iotools/__init__.py

@@ -5,8 +5,6 @@
 from pvlib.iotools.surfrad import read_surfrad  # noqa: F401
 from pvlib.iotools.midc import read_midc  # noqa: F401
 from pvlib.iotools.midc import read_midc_raw_data_from_nrel  # noqa: F401
-from pvlib.iotools.ecmwf_macc import read_ecmwf_macc  # noqa: F401
-from pvlib.iotools.ecmwf_macc import get_ecmwf_macc  # noqa: F401
 from pvlib.iotools.crn import read_crn  # noqa: F401
 from pvlib.iotools.solrad import read_solrad  # noqa: F401
 from pvlib.iotools.psm3 import get_psm3  # noqa: F401