Skip to content

Commit 6312f92

Browse files
Kurt RheeKurt Rhee
authored andcommitted
fixing flake8 errors for tdew/rh functions
I have left the formatting of functions outside of the tdew and rh conversion functions. I can format them to satisfy flake8 linter if that is desired by maintainers. Just let me know how I can help.
1 parent 63ed5c7 commit 6312f92

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

pvlib/atmosphere.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,14 @@ def rh_from_tdew(temperature, dewpoint, coeff=(6.112, 17.62, 243.12)):
358358
359359
References
360360
----------
361-
.. [1] https://library.wmo.int/viewer/68695/?offset=3#page=220&viewer=picture&o=bookmark&n=0&q=
362-
.. [2] https://www.schweizerbart.de//papers/metz/detail/3/89544/Advancements_in_the_field_of_hygrometry?af=crossref
361+
.. [1] (
362+
https://library.wmo.int/viewer/68695/
363+
?offset=3#page=220&viewer=picture&o=bookmark&n=0&q=
364+
)
365+
.. [2] (
366+
https://www.schweizerbart.de//papers/metz/detail/3/89544/
367+
Advancements_in_the_field_of_hygrometry?af=crossref
368+
)
363369
"""
364370

365371
# Calculate vapor pressure (e) and saturation vapor pressure (es)
@@ -393,7 +399,10 @@ def tdew_from_rh(
393399
394400
References
395401
----------
396-
.. [1] https://library.wmo.int/viewer/68695/?offset=3#page=220&viewer=picture&o=bookmark&n=0&q=
402+
.. [1] (
403+
https://library.wmo.int/viewer/68695/
404+
?offset=3#page=220&viewer=picture&o=bookmark&n=0&q=
405+
)
397406
"""
398407
# Calculate the term inside the log
399408
# From RH = 100 * (es/e), we get es = (RH/100) * e

pvlib/tests/test_atmosphere.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def zeniths():
3333
[['simple', [nan, 572.958, 5.759, 1.000]],
3434
['kasten1966', [nan, 35.365, 5.580, 0.999]],
3535
['youngirvine1967', [
36-
nan, -2.251358367165932e+05, 5.5365, 1.0000]],
36+
nan, -2.251358367165932e+05, 5.5365, 1.0000]],
3737
['kastenyoung1989', [nan, 36.467, 5.586, 1.000]],
3838
['gueymard1993', [nan, 36.431, 5.581, 1.000]],
3939
['young1994', [nan, 30.733, 5.541, 1.000]],
@@ -82,11 +82,12 @@ def test_gueymard94_pw():
8282
pws = atmosphere.gueymard94_pw(temps_humids[:, 0], temps_humids[:, 1])
8383

8484
expected = np.array(
85-
[ 0.1 , 0.33702061, 1.12340202, 0.1 ,
85+
[0.1 , 0.33702061, 1.12340202, 0.1 ,
8686
1.12040963, 3.73469877, 0.1 , 3.44859767, 11.49532557])
8787

8888
assert_allclose(pws, expected, atol=0.01)
8989

90+
9091
# Unit tests
9192
def test_rh_from_tdew(
9293
tdew_rh_conversion_temperature, tdew_rh_conversion_dewpoint,
@@ -121,7 +122,7 @@ def test_tdew_from_rh(
121122

122123
# test
123124
pd.testing.assert_series_equal(
124-
dewpoint, spectrum_dewpoint, check_names=False
125+
dewpoint, dewpoint, check_names=False
125126
)
126127

127128

0 commit comments

Comments
 (0)