Change method of multi-inheritance to allow kwargs in parent class of LocalizedPVSystem and LocalizedSingleAxisTracker (#330)

* remove superfluous keyword arguments

If keyword arguments are present a TypeError will be raised, so it is
better to remove it.

* Revert "remove superfluous keyword arguments"

This reverts commit 45e0518.

* use class names instead of super for multiple inheritance

* fix test, because 'my name' is expected if my name is given

* use class names instead of super for multiple inheritance

I have overseen this class so I had to change it in the same way as in
commit 6d1beaf.

* make pep8 a little happier

* add whatsnewfile for 0.4.6

* add whatsnew entry for PR 330

* extend whatsnew entry

Author: uvchik

docs/sphinx/source/conf.py

@@ -100,7 +100,7 @@ def __getattr__(cls, name):
 
 # List of patterns, relative to source directory, that match files and
 # directories to ignore when looking for source files.
-exclude_patterns = []
+exclude_patterns = ['whatsnew/*']
 
 # The reST default role (used for this markup: `text`) to use for all
 # documents.

docs/sphinx/source/whatsnew.rst

@@ -6,6 +6,7 @@ What's New
 
 These are new features and improvements of note in each release.
 
+.. include:: whatsnew/v0.4.6.rst
 .. include:: whatsnew/v0.4.5.txt
 .. include:: whatsnew/v0.4.4.txt
 .. include:: whatsnew/v0.4.3.txt

docs/sphinx/source/whatsnew/v0.4.6.rst

@@ -0,0 +1,31 @@
+.. _whatsnew_0460:
+
+v0.4.6 ()
+---------
+
+
+Bug fixes
+~~~~~~~~~
+
+* Method of multi-inheritance has changed to make it possible to use kwargs in
+  the parent classes of LocalizedPVSystem and LocalizedSingleAxisTracker
+  (:issue:`330`)
+
+
+Enhancements
+~~~~~~~~~~~~
+
+
+API Changes
+~~~~~~~~~~~
+
+
+Documentation
+~~~~~~~~~~~~~
+
+
+Contributors
+~~~~~~~~~~~~
+
+* Will Holmgren
+* Uwe Krien

pvlib/location.py

@@ -79,10 +79,6 @@ def __init__(self, latitude, longitude, tz='UTC', altitude=0,
 
         self.name = name
 
-        # needed for tying together Location and PVSystem in LocalizedPVSystem
-        # if LocalizedPVSystem signature is reversed
-        # super(Location, self).__init__(**kwargs)
-
     def __repr__(self):
         attrs = ['name', 'latitude', 'longitude', 'altitude', 'tz']
         return ('Location: \n  ' + '\n  '.join(

pvlib/pvsystem.py

@@ -149,9 +149,6 @@ def __init__(self,
 
         self.racking_model = racking_model
 
-        # needed for tying together Location and PVSystem in LocalizedPVSystem
-        super(PVSystem, self).__init__(**kwargs)
-
     def __repr__(self):
         attrs = ['name', 'surface_tilt', 'surface_azimuth', 'module',
                  'inverter', 'albedo', 'racking_model']
@@ -584,7 +581,8 @@ def __init__(self, pvsystem=None, location=None, **kwargs):
                           list(loc_dict.items()) +
                           list(kwargs.items()))
 
-        super(LocalizedPVSystem, self).__init__(**new_kwargs)
+        PVSystem.__init__(self, **new_kwargs)
+        Location.__init__(self, **new_kwargs)
 
     def __repr__(self):
         attrs = [

pvlib/test/test_pvsystem.py

@@ -751,7 +751,7 @@ def test_LocalizedPVSystem___repr__():
                                                   inverter='blarg',
                                                   name='my name')
 
-    expected = 'LocalizedPVSystem: \n  name: None\n  latitude: 32\n  longitude: -111\n  altitude: 0\n  tz: UTC\n  surface_tilt: 0\n  surface_azimuth: 180\n  module: blah\n  inverter: blarg\n  albedo: 0.25\n  racking_model: open_rack_cell_glassback'
+    expected = 'LocalizedPVSystem: \n  name: my name\n  latitude: 32\n  longitude: -111\n  altitude: 0\n  tz: UTC\n  surface_tilt: 0\n  surface_azimuth: 180\n  module: blah\n  inverter: blarg\n  albedo: 0.25\n  racking_model: open_rack_cell_glassback'
 
     assert localized_system.__repr__() == expected
 

pvlib/tracking.py

@@ -38,7 +38,6 @@ def __repr__(self):
         pvsystem_repr = '\n'.join(pvsystem_repr.split('\n')[1:])
         return sat_repr + '\n' + pvsystem_repr
 
-
     def singleaxis(self, apparent_zenith, apparent_azimuth):
         tracking_data = singleaxis(apparent_zenith, apparent_azimuth,
                                    self.axis_tilt, self.axis_azimuth,
@@ -162,14 +161,15 @@ def __init__(self, pvsystem=None, location=None, **kwargs):
                           list(loc_dict.items()) +
                           list(kwargs.items()))
 
-        super(LocalizedSingleAxisTracker, self).__init__(**new_kwargs)
+        SingleAxisTracker.__init__(self, **new_kwargs)
+        Location.__init__(self, **new_kwargs)
 
     def __repr__(self):
         attrs = ['latitude', 'longitude', 'altitude', 'tz']
         return ('Localized' +
-            super(LocalizedSingleAxisTracker, self).__repr__() + '\n  ' +
-            '\n  '.join(
-                (attr + ': ' + str(getattr(self, attr)) for attr in attrs)))
+                super(LocalizedSingleAxisTracker, self).__repr__() + '\n  ' +
+                '\n  '.join(
+                    (attr + ': ' + str(getattr(self, attr)) for attr in attrs)))
 
 
 def singleaxis(apparent_zenith, apparent_azimuth,