Skip to content

Commit dae7326

Browse files
committed
Update from solar_zenith to ghi
Update docs\sphinx\source\whatsnew\v0.11.3.rst
1 parent fb84dfc commit dae7326

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/sphinx/source/whatsnew/v0.11.3.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Deprecations
1010

1111
Enhancements
1212
~~~~~~~~~~~~
13-
13+
Fix syntax for unshaded ground fraction (:issue:`2245`, :pull:`2359`)
1414

1515
Documentation
1616
~~~~~~~~~~~~~
@@ -36,3 +36,4 @@ Contributors
3636
~~~~~~~~~~~~
3737
* Rajiv Daxini (:ghuser:`RDaxini`)
3838
* Mark Campanelli (:ghuser:`markcampanelli`)
39+
* Jason Lun Leung (:ghuser:`jason-rpkt`)

pvlib/bifacial/infinite_sheds.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -260,11 +260,10 @@ def get_irradiance_poa(surface_tilt, surface_azimuth, solar_zenith,
260260
Returns
261261
-------
262262
output : dict or DataFrame
263-
Output is a DataFrame when solar_zenith is a Series.
264-
solar_zenith is the one that sets the output type.
263+
Output is a "pandas.DataFrame" when "ghi" is a Series.
264+
Otherwise it is a dict of "numpy.ndarray"
265265
See Issue #2245
266-
See Notes for
267-
descriptions of content.
266+
See Notes for descriptions of content.
268267
269268
Notes
270269
-----
@@ -375,7 +374,7 @@ def get_irradiance_poa(surface_tilt, surface_azimuth, solar_zenith,
375374
'poa_global': poa_global, 'poa_direct': poa_direct,
376375
'poa_diffuse': poa_diffuse, 'poa_ground_diffuse': poa_gnd_pv,
377376
'poa_sky_diffuse': poa_sky_pv, 'shaded_fraction': f_x}
378-
if isinstance(solar_zenith, pd.Series):
377+
if isinstance(ghi, pd.Series):
379378
output = pd.DataFrame(output)
380379
return output
381380

0 commit comments

Comments
 (0)