python >= 3.6, add scipy 1.2.0 to min requirements (#1035)

* add scipy==1.2.0 to min requirements

* missed a needs numpy 10

* revert an import change in test_location

* whats new

* add missing requires_tables

* import cleanup. fix stray requires_scipy

* and fix new requires_scipy marks

* remove unneeded pytest.param

* fix depedency specs

* lint

* sdm.py import clean up

* move 3.5 packages to pip. spec versions in all yml files

* require python 3.6 or greater

* remove 3.5 ci, rename 35 min file

* update ci for 36

* remove from readme

* installation instructions

* fix python 3.5 references in contributing

Author: wholmgren

README.md

@@ -105,10 +105,6 @@ Installation
 pvlib-python releases may be installed using the ``pip`` and ``conda`` tools.
 Please see the [Installation page](http://pvlib-python.readthedocs.io/en/stable/installation.html) of the documentation for complete instructions.
 
-pvlib-python is compatible with Python 3.5 and above.
-
-**Python 2.7 support ended on June 1, 2019, with pvlib-python 0.6.3.**
-
 
 Contributing
 ============

ci/azure/conda_linux.yml

@@ -8,10 +8,8 @@ jobs:
     vmImage: ${{ parameters.vmImage }}
   strategy:
     matrix:
-      Python35:
-        python.version: '35'
-      Python35-min:
-        python.version: '35'
+      Python36-min:
+        python.version: '36'
         suffix: '-min'
       Python36:
         python.version: '36'

ci/azure/conda_windows.yml

@@ -8,8 +8,6 @@ jobs:
     vmImage: ${{ parameters.vmImage }}
   strategy:
     matrix:
-      Python35-windows:
-        python.version: '35'
       Python36-windows:
         python.version: '36'
       Python37-windows:

ci/azure/posix.yml

@@ -8,8 +8,6 @@ jobs:
     vmImage: ${{ parameters.vmImage }}
   strategy:
     matrix:
-      Python35:
-        python.version: '3.5'
       Python36:
         python.version: '3.6'
       Python37:

ci/requirements-py35.yml

@@ -9,11 +9,12 @@ dependencies:
     - pytest-cov
     - pytest-mock
     - pytest-timeout
-    - python=3.5
+    - python=3.6
     - pytz
     - requests
     - pip:
         - numpy==1.12.0
         - pandas==0.22.0
+        - scipy==1.2.0
         - pytest-rerunfailures # conda version is >3.6
         - pytest-remotedata # conda package is 0.3.0, needs > 0.3.1

ci/requirements-py35-min.yml renamed to ci/requirements-py36-min.yml

@@ -9,8 +9,8 @@ dependencies:
     - netcdf4
     - nose
     - numba
-    - numpy
-    - pandas
+    - numpy >= 1.12.0
+    - pandas >= 0.22.0
     - pip
     - pytables  # tables when using pip+PyPI
     - pytest
@@ -22,7 +22,7 @@ dependencies:
     - python=3.6
     - pytz
     - requests
-    - scipy
+    - scipy >= 1.2.0
     - shapely  # pvfactors dependency
     - siphon  # conda-forge
     - statsmodels

ci/requirements-py36.yml

@@ -9,8 +9,8 @@ dependencies:
     - netcdf4
     - nose
     - numba
-    - numpy
-    - pandas
+    - numpy >= 1.12.0
+    - pandas >= 0.22.0
     - pip
     - pytables  # tables when using pip+PyPI
     - pytest
@@ -22,7 +22,7 @@ dependencies:
     - python=3.7
     - pytz
     - requests
-    - scipy
+    - scipy >= 1.2.0
     - shapely  # pvfactors dependency
     - siphon  # conda-forge
     - statsmodels

ci/requirements-py37.yml

@@ -9,8 +9,8 @@ dependencies:
     - netcdf4
     - nose
     - numba
-    - numpy
-    - pandas
+    - numpy >= 1.12.0
+    - pandas >= 0.22.0
     - pip
     - pytables  # tables when using pip+PyPI
     - pytest
@@ -22,7 +22,7 @@ dependencies:
     - python=3.8
     - pytz
     - requests
-    - scipy
+    - scipy >= 1.2.0
     - shapely  # pvfactors dependency
     - siphon  # conda-forge
     - statsmodels

ci/requirements-py38.yml

@@ -196,8 +196,6 @@ pvlib python generally follows the `PEP 8 -- Style Guide for Python Code
 <https://www.python.org/dev/peps/pep-0008/>`_. Maximum line length for code
 is 79 characters.
 
-Code must be compatible with Python 3.5 and above.
-
 pvlib python uses a mix of full and abbreviated variable names. See
 :ref:`variables_style_rules`. We could be better about consistency.
 Prefer full names for new contributions. This is especially important
@@ -475,9 +473,10 @@ PVSystem method is called through ``ModelChain.run_model``.
         mc.run_model(times)
 
         # assertion fails if PVSystem.sapm is not called once
-        # if using returned m, prefer this over m.assert_called_once()
-        # for compatibility with python < 3.6
-        assert m.call_count == 1
+        m.assert_called_once()
+
+        # use `assert m.call_count == num` if function should be called
+        # more than once
 
         # ensure that dc attribute now exists and is correct type
         assert isinstance(mc.dc, (pd.Series, pd.DataFrame))