Skip to content

Commit fe7ab2a

Browse files
Add fixmes for remaining items to do
1 parent 123fd99 commit fe7ab2a

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

pvlib/pvsystem.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3028,7 +3028,7 @@ def combine_loss_factors(index, *losses, fill_method='ffill'):
30283028
def _negative_total_power(current, *args):
30293029
"""
30303030
Compute negative of total power generated by devices in series at
3031-
specified current.
3031+
specified current. Designed for use by scipy.optimize.minimize.
30323032
"""
30333033
return -np.sum(current * v_from_i(current, *args))
30343034

@@ -3043,6 +3043,8 @@ def max_power_point_mismatched(
30433043
i_mp_ic=None,
30443044
):
30453045
"""
3046+
FIXME Replace this with proper docstring.
3047+
30463048
Compute maximum power info for (possibly) mismatched set of devices in
30473049
series. When using this serially on time-series data, passing i_mp_ic from
30483050
previous step may speed up computation. Algorithm falls back to automated

pvlib/tests/test_pvsystem.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2555,6 +2555,7 @@ def test_Array_temperature_missing_parameters(model, keys):
25552555
@pytest.mark.parametrize(
25562556
'inputs',
25572557
[
2558+
# FIXME Need many more argument combinations in additional test cases.
25582559
{
25592560
"photocurrent": 6.2,
25602561
"saturation_current": 1.0e-8,
@@ -2645,13 +2646,12 @@ def test_max_power_point_mismatched(inputs):
26452646
nNsVth,
26462647
)
26472648

2649+
# FIXME Replace this with test assertions.
26482650
print(result)
26492651

26502652

26512653
def test_max_power_point_mismatched_unsuccessful_solver(monkeypatch):
2652-
"""
2653-
Test errored max power point computation where solver is unsuccessful.
2654-
"""
2654+
"""Test mismatched max power point computation where solver is unsuccessful."""
26552655
photocurrent = 6.2
26562656
saturation_current = 1.0e-8
26572657
resistance_series = 0.0001
@@ -2684,4 +2684,5 @@ def minimize_monkeypatched(*_, **__):
26842684
nNsVth,
26852685
)
26862686

2687+
# FIXME Replace this with test assertions.
26872688
print(e_info)

0 commit comments

Comments
 (0)