-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Description
I think that clearsky.ineichen is a disaster of a function. There's some unnecessary complexity inherited from PVLIB Matlab, and some additional complexity that I wrongly added.
In the spirit of simple functions, I think we should:
- remove the
time, latitude, location
arguments in favor ofapparent_zenith
- make
airmass
a required argument - remove the ability for the function to calculate it's own solar position and airmass
- remove the ability for the function to look up linke turbidity
The Location
class's get_clearsky
method, or similar, can provide the higher-level features.
My simplified solis PR #148 might provide some inspiration.