-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
pvlib-python/pvlib/bifacial/infinite_sheds.py
Line 146 in 7e88d21
| y = 0.5 * (cosd(psi_t_shaded) + cst) |
I think this should be:
because in the reference frame of the module surface the angle pointing along the slant height to the sky is actually zero, surface_tilt itself, then the angle from the horizontal to the top of the next row is psi_t_shaded so finally this angle from the slant height all the way up to the top of the next row is surface_tilt + psi_t_shaded:
For example, this is why if psi_t_shaded is zero, then the view factor should collapse to the isotropic view factor
The actual value difference between the two formulas can be quite small when psi_t_shaded is close to zero (eg less than 5°), but it's significant when as the masking angle is larger (eg greater than 5°).
