From cec320157ea79387fcbfdec28a4e2f51c4ee1465 Mon Sep 17 00:00:00 2001 From: Lakshya Garg <72099449+Lakshyadevelops@users.noreply.github.com> Date: Mon, 20 Mar 2023 02:48:07 +0530 Subject: [PATCH 1/5] resolved clarify f_x --- pvlib/bifacial/infinite_sheds.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pvlib/bifacial/infinite_sheds.py b/pvlib/bifacial/infinite_sheds.py index 78e1a0f2a0..c294a57a2d 100644 --- a/pvlib/bifacial/infinite_sheds.py +++ b/pvlib/bifacial/infinite_sheds.py @@ -102,7 +102,7 @@ def _vf_row_sky_integ(f_x, surface_tilt, gcr, npoints=100): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded. [unitless] + Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] surface_tilt : numeric Surface tilt angle in degrees from horizontal, e.g., surface facing up = 0, surface facing horizon = 90. [degree] @@ -162,7 +162,7 @@ def _poa_sky_diffuse_pv(f_x, dhi, vf_shade_sky_integ, vf_noshade_sky_integ): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded. [unitless] + Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] dhi : numeric Diffuse horizontal irradiance (DHI). [W/m^2] vf_shade_sky_integ : numeric @@ -257,7 +257,7 @@ def _vf_row_ground_integ(f_x, surface_tilt, gcr, npoints=100): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded. [unitless] + Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] surface_tilt : numeric Surface tilt angle in degrees from horizontal, e.g., surface facing up = 0, surface facing horizon = 90. [degree] @@ -320,7 +320,7 @@ def _poa_ground_pv(f_x, poa_ground, f_gnd_pv_shade, f_gnd_pv_noshade): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded. [unitless] + Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] poa_ground : numeric Ground-reflected irradiance that would reach the row surface if the full ground was visible. poa_gnd_sky accounts for limited view of the From 40e6627049582d1ca0496ecd3c22e3a8844973d2 Mon Sep 17 00:00:00 2001 From: Lakshya Garg <72099449+Lakshyadevelops@users.noreply.github.com> Date: Mon, 20 Mar 2023 03:14:58 +0530 Subject: [PATCH 2/5] done pep8 --- pvlib/bifacial/infinite_sheds.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/pvlib/bifacial/infinite_sheds.py b/pvlib/bifacial/infinite_sheds.py index c294a57a2d..31006ea346 100644 --- a/pvlib/bifacial/infinite_sheds.py +++ b/pvlib/bifacial/infinite_sheds.py @@ -102,7 +102,8 @@ def _vf_row_sky_integ(f_x, surface_tilt, gcr, npoints=100): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] + Fraction of row slant height from the bottom that is shaded from + direct irradiance. [unitless] surface_tilt : numeric Surface tilt angle in degrees from horizontal, e.g., surface facing up = 0, surface facing horizon = 90. [degree] @@ -162,7 +163,8 @@ def _poa_sky_diffuse_pv(f_x, dhi, vf_shade_sky_integ, vf_noshade_sky_integ): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] + Fraction of row slant height from the bottom that is shaded from + direct irradiance. [unitless] dhi : numeric Diffuse horizontal irradiance (DHI). [W/m^2] vf_shade_sky_integ : numeric @@ -257,7 +259,8 @@ def _vf_row_ground_integ(f_x, surface_tilt, gcr, npoints=100): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] + Fraction of row slant height from the bottom that is shaded from + direct irradiance. [unitless] surface_tilt : numeric Surface tilt angle in degrees from horizontal, e.g., surface facing up = 0, surface facing horizon = 90. [degree] @@ -320,7 +323,8 @@ def _poa_ground_pv(f_x, poa_ground, f_gnd_pv_shade, f_gnd_pv_noshade): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] + Fraction of row slant height from the bottom that is shaded from + direct irradiance. [unitless] poa_ground : numeric Ground-reflected irradiance that would reach the row surface if the full ground was visible. poa_gnd_sky accounts for limited view of the From b8f5de6a489270669339274836c5220fc7daa7c7 Mon Sep 17 00:00:00 2001 From: Lakshya Garg <72099449+Lakshyadevelops@users.noreply.github.com> Date: Mon, 20 Mar 2023 03:26:27 +0530 Subject: [PATCH 3/5] tried autopep8 --- pvlib/bifacial/infinite_sheds.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pvlib/bifacial/infinite_sheds.py b/pvlib/bifacial/infinite_sheds.py index 31006ea346..7c83b138c7 100644 --- a/pvlib/bifacial/infinite_sheds.py +++ b/pvlib/bifacial/infinite_sheds.py @@ -9,6 +9,7 @@ from pvlib.shading import masking_angle from pvlib.irradiance import beam_component, aoi, haydavies + def _vf_ground_sky_integ(surface_tilt, surface_azimuth, gcr, height, pitch, max_rows=10, npoints=100, vectorize=False): """ @@ -163,7 +164,7 @@ def _poa_sky_diffuse_pv(f_x, dhi, vf_shade_sky_integ, vf_noshade_sky_integ): Parameters ---------- f_x : numeric - Fraction of row slant height from the bottom that is shaded from + Fraction of row slant height from the bottom that is shaded from direct irradiance. [unitless] dhi : numeric Diffuse horizontal irradiance (DHI). [W/m^2] From 7c6e5e2c5ee236397a497cb1d27b91edc8147e36 Mon Sep 17 00:00:00 2001 From: Lakshya Garg <72099449+Lakshyadevelops@users.noreply.github.com> Date: Mon, 20 Mar 2023 21:29:18 +0530 Subject: [PATCH 4/5] updated whatsnew.rst --- docs/sphinx/source/whatsnew.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew.rst b/docs/sphinx/source/whatsnew.rst index d32104e889..28bec1cdd4 100644 --- a/docs/sphinx/source/whatsnew.rst +++ b/docs/sphinx/source/whatsnew.rst @@ -1,7 +1,7 @@ .. _whatsnew: ********** -What's New +resolved issue #1677 : LakshyaDevelops ********** These are new features and improvements of note in each release. From b87f867a10227967d34a87a971536ca2b4279955 Mon Sep 17 00:00:00 2001 From: Lakshya Garg <72099449+Lakshyadevelops@users.noreply.github.com> Date: Mon, 20 Mar 2023 22:03:02 +0530 Subject: [PATCH 5/5] corrected whatsnew --- docs/sphinx/source/whatsnew.rst | 2 +- docs/sphinx/source/whatsnew/v0.9.6.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sphinx/source/whatsnew.rst b/docs/sphinx/source/whatsnew.rst index 28bec1cdd4..d32104e889 100644 --- a/docs/sphinx/source/whatsnew.rst +++ b/docs/sphinx/source/whatsnew.rst @@ -1,7 +1,7 @@ .. _whatsnew: ********** -resolved issue #1677 : LakshyaDevelops +What's New ********** These are new features and improvements of note in each release. diff --git a/docs/sphinx/source/whatsnew/v0.9.6.rst b/docs/sphinx/source/whatsnew/v0.9.6.rst index 06e7049a28..0cec6035f2 100644 --- a/docs/sphinx/source/whatsnew/v0.9.6.rst +++ b/docs/sphinx/source/whatsnew/v0.9.6.rst @@ -35,4 +35,4 @@ Requirements Contributors ~~~~~~~~~~~~ - +* Lakshya Garg (:ghuser:`Lakshyadevelops`)