From 21cf3bd9f8dca841ffa3a6dbea45fa28a17c67c9 Mon Sep 17 00:00:00 2001 From: Ioannis Sifnaios Date: Thu, 12 Dec 2024 10:41:47 +0100 Subject: [PATCH 1/3] make dni_extra a required parameter --- pvlib/irradiance.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index 1c735eb454..cd9e72d7fa 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -1528,7 +1528,7 @@ def poa_error(ghi): def ghi_from_poa_driesse_2023(surface_tilt, surface_azimuth, solar_zenith, solar_azimuth, poa_global, - dni_extra=None, airmass=None, albedo=0.25, + dni_extra, airmass=None, albedo=0.25, xtol=0.01, full_output=False): ''' @@ -1549,7 +1549,7 @@ def ghi_from_poa_driesse_2023(surface_tilt, surface_azimuth, Solar azimuth angle. [degree] poa_global : numeric Plane-of-array global irradiance, aka global tilted irradiance. [Wm⁻²] - dni_extra : numeric, optional + dni_extra : numeric Extraterrestrial direct normal irradiance. [Wm⁻²] airmass : numeric, optional Relative airmass (not adjusted for pressure). [unitless] From ed0b6cebe68851f8dbdcefbfa6a1e36fb4796872 Mon Sep 17 00:00:00 2001 From: Ioannis Sifnaios Date: Thu, 12 Dec 2024 10:48:19 +0100 Subject: [PATCH 2/3] update whatsnew --- docs/sphinx/source/whatsnew/v0.11.2.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst index 4434e10097..91da12a8f6 100644 --- a/docs/sphinx/source/whatsnew/v0.11.2.rst +++ b/docs/sphinx/source/whatsnew/v0.11.2.rst @@ -22,6 +22,8 @@ Bug Fixes (:issue:`1338`, :pull:`2227`) * Handle DST transitions that happen at midnight in :py:func:`pvlib.solarposition.hour_angle` (:issue:`2132` :pull:`2133`) +* Chnaged `dni_extra` to a required parameter in :py:func:`pvlib.irradiance.ghi_from_poa_driesse_2023` + (:issue:`2279` :pull:`2331`) Bug fixes ~~~~~~~~~ @@ -85,3 +87,4 @@ Contributors * Echedey Luis (:ghuser:`echedey-ls`) * Kevin Anderson (:ghuser:`kandersolar`) * Scott Nelson (:ghuser:`scttnlsn`) +* Ioannis Sifnaios (:ghuser:`IoannisSifnaios`) From 083276f45853b63fd3cce78948f9bf87f6c6dcf6 Mon Sep 17 00:00:00 2001 From: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> Date: Thu, 12 Dec 2024 10:56:51 +0100 Subject: [PATCH 3/3] Update docs/sphinx/source/whatsnew/v0.11.2.rst Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> --- docs/sphinx/source/whatsnew/v0.11.2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst index 91da12a8f6..3148ca388f 100644 --- a/docs/sphinx/source/whatsnew/v0.11.2.rst +++ b/docs/sphinx/source/whatsnew/v0.11.2.rst @@ -22,7 +22,7 @@ Bug Fixes (:issue:`1338`, :pull:`2227`) * Handle DST transitions that happen at midnight in :py:func:`pvlib.solarposition.hour_angle` (:issue:`2132` :pull:`2133`) -* Chnaged `dni_extra` to a required parameter in :py:func:`pvlib.irradiance.ghi_from_poa_driesse_2023` +* Changed ``dni_extra`` to a required parameter in :py:func:`pvlib.irradiance.ghi_from_poa_driesse_2023` (:issue:`2279` :pull:`2331`) Bug fixes