From 78436551f262933b73ad1bf7ab366bb93f560bab Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Fri, 14 Mar 2025 21:45:14 +0100 Subject: [PATCH 1/3] Change default method in Location.get_sun_rise_set_transit --- pvlib/location.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/location.py b/pvlib/location.py index d1c9b4e2db..230ce26a66 100644 --- a/pvlib/location.py +++ b/pvlib/location.py @@ -368,7 +368,7 @@ def get_airmass(self, times=None, solar_position=None, return airmass - def get_sun_rise_set_transit(self, times, method='pyephem', **kwargs): + def get_sun_rise_set_transit(self, times, method='spa', **kwargs): """ Calculate sunrise, sunset and transit times. @@ -376,7 +376,7 @@ def get_sun_rise_set_transit(self, times, method='pyephem', **kwargs): ---------- times : DatetimeIndex Must be localized to the Location - method : str, default 'pyephem' + method : str, default 'spa' 'pyephem', 'spa', or 'geometric' kwargs : From 785da727b5912d9d82355128d186574cedc4dc18 Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Fri, 14 Mar 2025 21:52:54 +0100 Subject: [PATCH 2/3] Update v0.11.3.rst --- docs/sphinx/source/whatsnew/v0.11.3.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.11.3.rst b/docs/sphinx/source/whatsnew/v0.11.3.rst index 829b86dea5..450adee03e 100644 --- a/docs/sphinx/source/whatsnew/v0.11.3.rst +++ b/docs/sphinx/source/whatsnew/v0.11.3.rst @@ -20,6 +20,8 @@ Breaking Changes Use :py:func:`~pvlib.spectrum.spectral_factor_firstsolar` instead. (:issue:`2130`, :pull:`2131`) * Remove deprecated :py:func:`!pvlib.spectrum.get_am15g` function; use :py:func:`~pvlib.spectrum.get_reference_spectra` instead. (:pull:`2409`) +* Change default method of :py:func:`~pvlib.location.Location.get_sun_rise_set_transit` + to 'spa' instead of 'pyephem'. Bug fixes ~~~~~~~~~ From 7767e8c8f1d97574221f7362628a1bf1eb3ea431 Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Sun, 16 Mar 2025 17:07:23 +0100 Subject: [PATCH 3/3] Update docs/sphinx/source/whatsnew/v0.11.3.rst Co-authored-by: Kevin Anderson --- docs/sphinx/source/whatsnew/v0.11.3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.11.3.rst b/docs/sphinx/source/whatsnew/v0.11.3.rst index 450adee03e..82ce0a1e32 100644 --- a/docs/sphinx/source/whatsnew/v0.11.3.rst +++ b/docs/sphinx/source/whatsnew/v0.11.3.rst @@ -21,7 +21,7 @@ Breaking Changes * Remove deprecated :py:func:`!pvlib.spectrum.get_am15g` function; use :py:func:`~pvlib.spectrum.get_reference_spectra` instead. (:pull:`2409`) * Change default method of :py:func:`~pvlib.location.Location.get_sun_rise_set_transit` - to 'spa' instead of 'pyephem'. + to ``'spa'`` instead of ``'pyephem'``. (:pull:`2410`) Bug fixes ~~~~~~~~~