From 84bfcffce0fe322e17f9516dbe21e7d32f2e75ea Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 1 Jul 2025 09:07:35 -0600 Subject: [PATCH 1/4] aoi->sapm --- pvlib/modelchain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/modelchain.py b/pvlib/modelchain.py index 0f5fc5f363..dd96d8d06c 100644 --- a/pvlib/modelchain.py +++ b/pvlib/modelchain.py @@ -806,7 +806,7 @@ def infer_aoi_model(self): 'system.arrays[i].module_parameters. Check that ' 'the module_parameters for all Arrays in ' 'system.arrays contain parameters for the ' - 'physical, aoi, ashrae, martin_ruiz or interp ' + 'physical, sapm, ashrae, martin_ruiz or interp ' 'model; explicitly set the model with the ' 'aoi_model kwarg; or set aoi_model="no_loss".') From e2a61c4d1406564ca2681a868c86d583a438c104 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 1 Jul 2025 09:13:30 -0600 Subject: [PATCH 2/4] other misc typos --- pvlib/modelchain.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pvlib/modelchain.py b/pvlib/modelchain.py index dd96d8d06c..9f65f866b5 100644 --- a/pvlib/modelchain.py +++ b/pvlib/modelchain.py @@ -31,7 +31,7 @@ # 'cell_temperature' overrides ModelChain.temperature_model and sets # ModelChain.cell_temperature to the data. If 'module_temperature' is provided, # overrides ModelChain.temperature_model with -# pvlib.temperature.sapm_celL_from_module +# pvlib.temperature.sapm_cell_from_module TEMPERATURE_KEYS = ('module_temperature', 'cell_temperature') DATA_KEYS = WEATHER_KEYS + POA_KEYS + TEMPERATURE_KEYS @@ -46,7 +46,7 @@ # for Flat-Plate Photovoltaic Arrays. SAND85-0330. Albuquerque, NM: # Sandia National Laboratories. Accessed September 3, 2013: # http://prod.sandia.gov/techlib/access-control.cgi/1985/850330.pdf -# pvlib python does not implement that model, so use the SAPM instead. +# pvlib-python does not implement that model, so it uses the SAPM instead. PVWATTS_CONFIG = dict( dc_model='pvwatts', ac_model='pvwatts', losses_model='pvwatts', transposition_model='perez', aoi_model='physical', @@ -84,7 +84,7 @@ def get_orientation(strategy, **kwargs): surface_tilt = 0 else: raise ValueError('invalid orientation strategy. strategy must ' - 'be one of south_at_latitude, flat,') + 'be one of south_at_latitude_tilt, flat,') return surface_tilt, surface_azimuth @@ -190,12 +190,12 @@ class ModelChainResult: cell_temperature: Optional[PerArray[pd.Series]] = field(default=None) """Series (or tuple of Series, one for each array) containing cell - temperature (C). + temperature (°C). """ effective_irradiance: Optional[PerArray[pd.Series]] = field(default=None) """Series (or tuple of Series, one for each array) containing effective - irradiance (W/m2) which is total plane-of-array irradiance adjusted for + irradiance (Wm⁻²) which is total plane-of-array irradiance adjusted for reflections and spectral content. """ @@ -215,12 +215,12 @@ class ModelChainResult: dc_ohmic_losses: Optional[PerArray[pd.Series]] = field(default=None) """Series (or tuple of Series, one for each array) containing DC ohmic - loss (W) calculated by ``ModelChain.dc_ohmic_model``. + losses (W) calculated by ``ModelChain.dc_ohmic_model``. """ # copies of input data, for user convenience weather: Optional[PerArray[pd.DataFrame]] = None - """DataFrame (or tuple of DataFrame, one for each array) contains a + """DataFrame (or tuple of DataFrame, one for each array) containing a copy of the input weather data. """ From 15f444adba11101201693c556e59c85bd23f4824 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 1 Jul 2025 09:18:21 -0600 Subject: [PATCH 3/4] grammar, unit --- pvlib/modelchain.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pvlib/modelchain.py b/pvlib/modelchain.py index 9f65f866b5..7b0c242274 100644 --- a/pvlib/modelchain.py +++ b/pvlib/modelchain.py @@ -161,9 +161,9 @@ class ModelChainResult: # per DC array information total_irrad: Optional[PerArray[pd.DataFrame]] = field(default=None) - """ DataFrame (or tuple of DataFrame, one for each array) containing - columns ``'poa_global'``, ``'poa_direct'`` ``'poa_diffuse'``, - ``poa_sky_diffuse'``, ``'poa_ground_diffuse'`` (W/m2); see + """ DataFrame (or tuple of DataFrame, one for each array containing + columns ``'poa_global'``, ``'poa_direct'``, ``'poa_diffuse'``, + ``poa_sky_diffuse'``, and ``'poa_ground_diffuse'`` (Wm⁻²); see :py:func:`~pvlib.irradiance.get_total_irradiance` for details. """ From 41d29053123b499ca82d783a87e420489efee570 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 1 Jul 2025 09:50:54 -0600 Subject: [PATCH 4/4] Update pvlib/modelchain.py Co-authored-by: Kevin Anderson --- pvlib/modelchain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/modelchain.py b/pvlib/modelchain.py index 7b0c242274..52732ebaeb 100644 --- a/pvlib/modelchain.py +++ b/pvlib/modelchain.py @@ -161,7 +161,7 @@ class ModelChainResult: # per DC array information total_irrad: Optional[PerArray[pd.DataFrame]] = field(default=None) - """ DataFrame (or tuple of DataFrame, one for each array containing + """ DataFrame (or tuple of DataFrame, one for each array) containing columns ``'poa_global'``, ``'poa_direct'``, ``'poa_diffuse'``, ``poa_sky_diffuse'``, and ``'poa_ground_diffuse'`` (Wm⁻²); see :py:func:`~pvlib.irradiance.get_total_irradiance` for details.