From 657674267385da76a7942a30b33209e44003e8bc Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Fri, 1 Aug 2025 11:49:35 +0200 Subject: [PATCH 1/2] Update spa_python doc string --- pvlib/solarposition.py | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/pvlib/solarposition.py b/pvlib/solarposition.py index 7284191d68..15419f0cbe 100644 --- a/pvlib/solarposition.py +++ b/pvlib/solarposition.py @@ -285,7 +285,7 @@ def spa_python(time, latitude, longitude, Calculate the solar position using a python implementation of the NREL SPA algorithm. - The details of the NREL SPA algorithm are described in [1]_. + The details of the NREL SPA algorithm are described in [1]_, [2]_. If numba is installed, the functions can be compiled to machine code and the function can be multithreaded. @@ -328,25 +328,26 @@ def spa_python(time, latitude, longitude, ------- DataFrame The DataFrame will have the following columns: - apparent_zenith (degrees), - zenith (degrees), - apparent_elevation (degrees), - elevation (degrees), - azimuth (degrees), - equation_of_time (minutes). + - apparent_zenith (degrees), + - zenith (degrees), + - apparent_elevation (degrees), + - elevation (degrees), + - azimuth (degrees), + - equation_of_time (minutes). References ---------- .. [1] I. Reda and A. Andreas, Solar position algorithm for solar radiation applications. Solar Energy, vol. 76, no. 5, pp. 577-589, 2004. + :doi:`10.1016/j.solener.2003.12.003`. .. [2] I. Reda and A. Andreas, Corrigendum to Solar position algorithm for solar radiation applications. Solar Energy, vol. 81, no. 6, p. 838, - 2007. + 2007. :doi:`10.1016/j.solener.2007.01.003`. - .. [3] USNO delta T: - https://maia.usno.navy.mil/products/deltaT + .. [3] `USNO delta T: + `_ See also -------- From b2f74ca2cfee8c7310b12b0cf1727b86f5b94ca2 Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Fri, 1 Aug 2025 23:46:26 +0200 Subject: [PATCH 2/2] Update pvlib/solarposition.py Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com> --- pvlib/solarposition.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/solarposition.py b/pvlib/solarposition.py index 15419f0cbe..ba861c9d82 100644 --- a/pvlib/solarposition.py +++ b/pvlib/solarposition.py @@ -346,7 +346,7 @@ def spa_python(time, latitude, longitude, solar radiation applications. Solar Energy, vol. 81, no. 6, p. 838, 2007. :doi:`10.1016/j.solener.2007.01.003`. - .. [3] `USNO delta T: + .. [3] `U.S. Naval Observatory, delta T `_ See also