Adds ability for soiling.Hsu to accept arbitrary time intervals (other than 1 hour) #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
reviewed
Jun 13, 2020
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Some quick comments. Would also be good to add a test that uses non-hourly data.
cwhanse
reviewed
Jun 18, 2020
Member
Member
|
Other than the small whatsnew changes, the only thing I see is that the test has |
Closed
Member
|
FYI test failure is the shapely segfault |
wholmgren
approved these changes
Aug 27, 2020
Member
wholmgren
left a comment
wholmgren
left a comment
There was a problem hiding this comment.
a couple of suggestions/questions but ok to merge
Member
|
Thanks @jsstein and @kanderso-nrel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).