Merge pull request #88 from pwa-builder/pwabuilder_issue1245

PWABuilder Issue 1245

Author: JudahGabriel

lib/manifestTools/validationRules/shortNameRequired.js

@@ -124,7 +124,13 @@ function createApps(w3cManifestInfo, rootDir, platforms, options, href, callback
   }
 
   // determine the path where the app will be created
-  options.appName = utils.sanitizeName(w3cManifestInfo.content.short_name.replace(/[^a-zA-Z0-9]/g, '_'));
+  var appName = w3cManifestInfo.content.short_name || w3cManifestInfo.content.name;
+
+  if (!appName) {
+    return Q.reject(new Error("manifest missing short_name or name (required field)")).nodeify(callback);
+  }
+
+  options.appName = utils.sanitizeName(appName);
   var generatedAppDir = path.join(rootDir, options.appName);
 
   // Add timestamp to manifest information for telemetry purposes only

lib/manifestTools/validationRules/shortNameRequiresSanitization.js

@@ -38,10 +38,11 @@ function newGuid () {
     s4() + '-' + s4() + s4() + s4();
 }
 
-function sanitizeName (name) {
+function sanitizeName(name) {
   var sanitizedName = name;
-  
+
   // Remove all invalid characters
+  sanitizedName = sanitizedName.replace(/[^a-zA-Z0-9]/g, '_');
   sanitizedName = sanitizedName.replace(/\s+/g, '');
 
   var currentLength;

lib/projectBuilder.js

@@ -1,6 +1,6 @@
 {
   "name": "pwabuilder-lib",
-  "version": "2.1.11",
+  "version": "2.1.12",
   "description": "PWA Builder Core Library",
   "repository": {
     "type": "git",