Skip to content
This repository was archived by the owner on Jan 14, 2022. It is now read-only.

Commit 636bb9c

Browse files
committed
take out suggestion for extended scope (pwa-builder/PWABuilder-CLI#245)
1 parent f54b2a6 commit 636bb9c

File tree

3 files changed

+8
-105
lines changed

3 files changed

+8
-105
lines changed

lib/manifestTools/validationRules/extendedScopeRequired.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

test/manifestTools.js

Lines changed: 8 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
var fs = require('fs'),
44
http = require('http'),
5-
path = require('path'),
5+
path = require('path'),
66
url = require('url');
77

88
var should = require('should');
99

1010
var manifestTools = require('../lib/manifestTools'),
1111
validationConstants = require('../lib/constants').validation;
12-
12+
1313
var manifestTypeDetector = require('../lib/manifestTools/manifestTypeDetector');
1414

1515
var responseFunction;
@@ -464,7 +464,7 @@ describe('Manifest Tools', function () {
464464
done();
465465
});
466466
});
467-
467+
468468
it('Should convert from Chrome OS manifest format to W3C manifest format', function() {
469469
var manifestInfo = {
470470
content: {
@@ -486,11 +486,11 @@ describe('Manifest Tools', function () {
486486
'background'
487487
]
488488
},
489-
format: 'chromeos'
489+
format: 'chromeos'
490490
};
491-
491+
492492
manifestTools.convertTo(manifestInfo, 'W3C', function(err, convertedManifest) {
493-
var result = manifestTypeDetector.detect(convertedManifest.content);
493+
var result = manifestTypeDetector.detect(convertedManifest.content);
494494
should.exist(result);
495495
result.should.be.equal('w3c');
496496
});
@@ -573,8 +573,8 @@ describe('Manifest Tools', function () {
573573
done();
574574
});
575575
});
576-
577-
it('Issue #88', function (done) {
576+
577+
it('Issue #88', function (done) {
578578
manifestTools.getManifestFromFile(inputFiles.issue88Manifest, function (err, manifestObject){
579579
var w3cmanifest = {
580580
content: manifestObject,
@@ -647,29 +647,5 @@ describe('Manifest Tools', function () {
647647
done();
648648
});
649649
});
650-
651-
it('Should recommend to specify scope rules', function (done) {
652-
var manifestInfo = {
653-
content: {
654-
'short_name': 'MyApp',
655-
'start_url': 'http://example.com/'
656-
},
657-
format: 'w3c'
658-
};
659-
660-
var expectedValidation = {
661-
'description': 'It is recommended to specify a set of rules that represent the navigation scope of the application',
662-
'platform': validationConstants.platforms.all,
663-
'level': validationConstants.levels.suggestion,
664-
'member': validationConstants.manifestMembers.mjs_extended_scope,
665-
'code': validationConstants.codes.requiredValue
666-
};
667-
668-
manifestTools.validateManifest(manifestInfo, ['ios', 'windows', 'firefox', 'chrome', 'android'], function (err, validationResults) {
669-
should.not.exist(err);
670-
validationResults.should.containEql(expectedValidation);
671-
done();
672-
});
673-
});
674650
});
675651
});

test/manifestTools/validations/extendedScopeRequired.js

Lines changed: 0 additions & 53 deletions
This file was deleted.

0 commit comments

Comments
 (0)