download icons to be compatible with windows10 uwp pwas

lee-leonardo · lee-leonardo · commit 68f6c31c4660 · 2020-06-03T17:32:02.000-07:00
diff --git a/lib/platformBase.js b/lib/platformBase.js
@@ -307,7 +307,7 @@ function PlatformBase (id, name, packageName, baseDir, extendedCfg) {
             return self.resolveEmbeddedIcon(manifest, icon, rootDir, imagesDir);
           }
 
-          var iconPath = icon.url || icon;
+          var iconPath = icon.url || icon.src || icon;
           var iconUrl = url.resolve(baseUrl, iconPath);
           var pathname = icon.fileName || url.parse(iconUrl).pathname;
           var iconFilePath = path.join(imagesDir, pathname);
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pwabuilder-lib",
-  "version": "2.0.7",
+  "version": "2.1.2",
   "description": "PWA Builder Core Library",
   "repository": {
     "type": "git",

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ function PlatformBase (id, name, packageName, baseDir, extendedCfg) {`
`307`	`307`	`return self.resolveEmbeddedIcon(manifest, icon, rootDir, imagesDir);`
`308`	`308`	`}`
`309`	`309`
`310`		`- var iconPath = icon.url \|\| icon;`
	`310`	`+ var iconPath = icon.url \|\| icon.src \|\| icon;`
`311`	`311`	`var iconUrl = url.resolve(baseUrl, iconPath);`
`312`	`312`	`var pathname = icon.fileName \|\| url.parse(iconUrl).pathname;`
`313`	`313`	`var iconFilePath = path.join(imagesDir, pathname);`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "pwabuilder-lib",`
`3`		`- "version": "2.0.7",`
	`3`	`+ "version": "2.1.2",`
`4`	`4`	`"description": "PWA Builder Core Library",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`