added some checking and casting to make split calls reliable

Author: lee-leonardo

lib/manifestTools/validationRules/w3cManifestSchema.js

@@ -40,7 +40,7 @@ module.exports = function (manifestContent, callback) {
       });
     }
 
-    var member = err.dataPath.split('/').pop();
+    var member = err.dataPath && typeof err.dataPath === "string" && err.dataPath.split('/').pop();
     if (err.code !== tv4.errorCodes.UNKNOWN_PROPERTY || (member && member.indexOf('_') < 0)) {
       validationResults.push({
         'description': message,

lib/processTools.js

@@ -14,7 +14,7 @@ var node_modules = 'node_modules';
 
 function writeOutput(text, bufferedOutput, source, title) {
 
-  var lines = (title + bufferedOutput + text).split(/\r?\n/);
+  var lines = ("" + title + bufferedOutput + text).split(/\r?\n/);
   bufferedOutput = lines.pop();    
 
   lines.forEach(function (line) {

lib/validations.js

@@ -42,6 +42,10 @@ function isExpectedValidationError(errorResult) {
 }
 
 function isExpectedCase(errorResult, w3cManifestInfo) {
+  if (!errorResult.member) {
+    return true;
+  }
+
   const errorParams = errorResult.member.split('/').slice(1) //example: /icons/0/purpose -> ['icons', '0', 'purpose']
   const isIconsPurpose = errorResult.member.includes("icons") && errorResult.member.includes("purpose");
   const isShortcuts = errorResult.member.includes("shortcuts");
@@ -56,9 +60,10 @@ function isExpectedCase(errorResult, w3cManifestInfo) {
 
     return w3cManifestInfo.content.icons
       && w3cManifestInfo.content.icons[index]
+      && w3cManifestInfo.content.icons[index].purpose 
       && w3cManifestInfo.content.icons[index].purpose.split(" ").filter(entry => {
         return (entry === "any" || entry === "maskable" || entry === "monochrome");
-    }).length > 0
+    }).length > 0;
   }
 
   return false;