Merge pull request #72 from pwa-builder/downloadIconsSupportSrc

JudahGabriel · web-flow · commit fe02545d60eb · 2020-06-26T09:28:06.000-07:00
Make name sanitization step consistent.
diff --git a/lib/projectBuilder.js b/lib/projectBuilder.js
@@ -111,7 +111,7 @@ function createApps (w3cManifestInfo, rootDir, platforms, options, href, callbac
   }
 
   // determine the path where the app will be created
-  options.appName = utils.sanitizeName(w3cManifestInfo.content.short_name);
+  options.appName = utils.sanitizeName(w3cManifestInfo.content.short_name.replace(/[^a-zA-Z0-9]/g, '_'));
   var generatedAppDir = path.join(rootDir, options.appName);
 
   // Add timestamp to manifest information for telemetry purposes only
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pwabuilder-lib",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "description": "PWA Builder Core Library",
   "repository": {
     "type": "git",

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ function createApps (w3cManifestInfo, rootDir, platforms, options, href, callbac`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`// determine the path where the app will be created`
`114`		`- options.appName = utils.sanitizeName(w3cManifestInfo.content.short_name);`
	`114`	`+ options.appName = utils.sanitizeName(w3cManifestInfo.content.short_name.replace(/[^a-zA-Z0-9]/g, '_'));`
`115`	`115`	`var generatedAppDir = path.join(rootDir, options.appName);`
`116`	`116`
`117`	`117`	`// Add timestamp to manifest information for telemetry purposes only`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "pwabuilder-lib",`
`3`		`- "version": "2.1.3",`
	`3`	`+ "version": "2.1.4",`
`4`	`4`	`"description": "PWA Builder Core Library",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`