Extract network_params and constants classes from common.hpp

pwojcikdev · pwojcikdev · commit 4e66d1035068 · 2026-04-09T23:40:07.000+02:00
Move ledger_constants, hardened_constants, node_constants,
voting_constants, portmapping_constants, bootstrap_constants,
network_params, and dev namespace into nano/secure/network_params.hpp/.cpp.

common.hpp no longer includes constants.hpp, epochs.hpp, or keypair.hpp,
making it significantly lighter. Files that need network_params or dev
constants now include network_params.hpp directly.

Add explicit chrono_literals and constants.hpp includes to headers that
relied on transitive includes through common.hpp.
diff --git a/nano/core_test/backend.cpp b/nano/core_test/backend.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/files.hpp>
 #include <nano/lib/logging.hpp>
 #include <nano/store/backend.hpp>
diff --git a/nano/core_test/block.cpp b/nano/core_test/block.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/block_uniquer.hpp>
 #include <nano/lib/blockbuilders.hpp>
 #include <nano/lib/blocks.hpp>
diff --git a/nano/core_test/difficulty.cpp b/nano/core_test/difficulty.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/block_type.hpp>
 #include <nano/lib/blocks.hpp>
 #include <nano/lib/config.hpp>
diff --git a/nano/core_test/epochs.cpp b/nano/core_test/epochs.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/epoch.hpp>
 #include <nano/secure/common.hpp>
 
diff --git a/nano/core_test/ledger_upgrades.cpp b/nano/core_test/ledger_upgrades.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/block_sideband.hpp>
 #include <nano/lib/block_type.hpp>
 #include <nano/lib/blockbuilders.hpp>
diff --git a/nano/core_test/message.cpp b/nano/core_test/message.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/crypto_lib/random_pool.hpp>
 #include <nano/lib/blockbuilders.hpp>
 #include <nano/lib/blocks.hpp>
diff --git a/nano/core_test/network_filter.cpp b/nano/core_test/network_filter.cpp
@@ -1,4 +1,5 @@
 #include <nano/lib/blockbuilders.hpp>
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/blocks.hpp>
 #include <nano/lib/network_filter.hpp>
 #include <nano/lib/stream.hpp>
diff --git a/nano/core_test/numbers.cpp b/nano/core_test/numbers.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/balance_formatting.hpp>
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/numbers_templ.hpp>
diff --git a/nano/core_test/scheduler_buckets.cpp b/nano/core_test/scheduler_buckets.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/blockbuilders.hpp>
 #include <nano/lib/blocks.hpp>
 #include <nano/secure/common.hpp>
diff --git a/nano/core_test/work_pool.cpp b/nano/core_test/work_pool.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/crypto_lib/random_pool.hpp>
 #include <nano/lib/blockbuilders.hpp>
 #include <nano/lib/blocks.hpp>
diff --git a/nano/lib/numbers.cpp b/nano/lib/numbers.cpp
@@ -3,6 +3,7 @@
 #include <nano/crypto_lib/secure_memory.hpp>
 #include <nano/lib/balance_formatting.hpp>
 #include <nano/lib/numbers.hpp>
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/utility.hpp>
 #include <nano/secure/common.hpp>
 
diff --git a/nano/node/active_elections.hpp b/nano/node/active_elections.hpp
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <nano/lib/config.hpp>
 #include <nano/lib/interval.hpp>
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/observer_set.hpp>
@@ -14,12 +15,15 @@
 #include <nano/node/vote_with_weight_info.hpp>
 #include <nano/secure/common.hpp>
 
+#include <chrono>
 #include <condition_variable>
 #include <deque>
 #include <memory>
 #include <thread>
 #include <unordered_map>
 
+
+using namespace std::chrono_literals;
 namespace nano
 {
 class active_elections_config final
diff --git a/nano/node/block_context.hpp b/nano/node/block_context.hpp
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <nano/lib/assert.hpp>
 #include <nano/node/block_source.hpp>
 #include <nano/secure/common.hpp>
 
diff --git a/nano/node/block_processor.hpp b/nano/node/block_processor.hpp
@@ -16,6 +16,8 @@
 #include <optional>
 #include <thread>
 
+using namespace std::chrono_literals;
+
 namespace nano
 {
 class block_processor_config final
diff --git a/nano/node/cementing_set.hpp b/nano/node/cementing_set.hpp
@@ -9,6 +9,7 @@
 #include <nano/secure/common.hpp>
 #include <nano/secure/fwd.hpp>
 
+#include <chrono>
 #include <boost/multi_index/hashed_index.hpp>
 #include <boost/multi_index/member.hpp>
 #include <boost/multi_index/ordered_index.hpp>
@@ -21,6 +22,8 @@
 #include <thread>
 #include <unordered_set>
 
+
+using namespace std::chrono_literals;
 namespace mi = boost::multi_index;
 
 namespace nano
diff --git a/nano/node/distributed_work.cpp b/nano/node/distributed_work.cpp
@@ -1,5 +1,6 @@
 #include <nano/boost/asio/bind_executor.hpp>
 #include <nano/lib/logging.hpp>
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/network_formatting.hpp>
 #include <nano/lib/thread_pool.hpp>
 #include <nano/node/distributed_work.hpp>
diff --git a/nano/node/endpoint.cpp b/nano/node/endpoint.cpp
@@ -1,5 +1,6 @@
 #include <nano/crypto/blake2/blake2.h>
 #include <nano/lib/blocks.hpp>
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/memory.hpp>
 #include <nano/lib/stream.hpp>
 #include <nano/lib/vote.hpp>
diff --git a/nano/node/ipc/flatbuffers_util.cpp b/nano/node/ipc/flatbuffers_util.cpp
@@ -1,3 +1,4 @@
+#include <nano/lib/assert.hpp>
 #include <nano/lib/block_type.hpp>
 #include <nano/lib/blocks.hpp>
 #include <nano/lib/numbers.hpp>
diff --git a/nano/node/local_block_broadcaster.hpp b/nano/node/local_block_broadcaster.hpp
@@ -1,6 +1,7 @@
 #pragma once
 
 #include <nano/lib/blocks.hpp>
+#include <nano/lib/constants.hpp>
 #include <nano/lib/interval.hpp>
 #include <nano/lib/locks.hpp>
 #include <nano/lib/numbers.hpp>
@@ -11,6 +12,7 @@
 #include <nano/node/fwd.hpp>
 #include <nano/secure/common.hpp>
 
+#include <chrono>
 #include <boost/multi_index/hashed_index.hpp>
 #include <boost/multi_index/mem_fun.hpp>
 #include <boost/multi_index/member.hpp>
@@ -22,6 +24,8 @@
 #include <thread>
 #include <unordered_set>
 
+
+using namespace std::chrono_literals;
 namespace mi = boost::multi_index;
 
 namespace nano
diff --git a/nano/node/local_vote_history.cpp b/nano/node/local_vote_history.cpp
@@ -1,4 +1,5 @@
 #include <nano/lib/vote.hpp>
+#include <nano/secure/network_params.hpp>
 #include <nano/node/local_vote_history.hpp>
 #include <nano/secure/common.hpp>
 
diff --git a/nano/node/migrations.cpp b/nano/node/migrations.cpp
@@ -1,3 +1,4 @@
+#include <nano/lib/config.hpp>
 #include <nano/lib/files.hpp>
 #include <nano/lib/logging.hpp>
 #include <nano/node/make_store.hpp>
diff --git a/nano/node/network.hpp b/nano/node/network.hpp
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <nano/lib/constants.hpp>
 #include <nano/lib/interval.hpp>
 #include <nano/lib/logging.hpp>
 #include <nano/lib/network_filter.hpp>
@@ -10,10 +11,13 @@
 #include <nano/node/transport/fwd.hpp>
 #include <nano/node/transport/tcp_channels.hpp>
 
+#include <chrono>
 #include <deque>
 #include <memory>
 #include <unordered_set>
 
+
+using namespace std::chrono_literals;
 namespace nano
 {
 class node;
diff --git a/nano/node/node_wrapper.hpp b/nano/node/node_wrapper.hpp
@@ -2,6 +2,7 @@
 
 #include <nano/lib/work.hpp>
 #include <nano/secure/common.hpp>
+#include <nano/secure/network_params.hpp>
 
 #include <boost/asio/io_context.hpp>
 
diff --git a/nano/node/nodeconfig.hpp b/nano/node/nodeconfig.hpp
@@ -8,6 +8,7 @@
 #include <nano/lib/threading.hpp>
 #include <nano/node/fwd.hpp>
 #include <nano/secure/common.hpp>
+#include <nano/secure/network_params.hpp>
 #include <nano/secure/generate_cache_flags.hpp>
 
 #include <chrono>
diff --git a/nano/node/peer_exclusion.cpp b/nano/node/peer_exclusion.cpp
@@ -1,3 +1,4 @@
+#include <nano/lib/assert.hpp>
 #include <nano/lib/container_info.hpp>
 #include <nano/node/peer_exclusion.hpp>
 
diff --git a/nano/node/repcrawler.hpp b/nano/node/repcrawler.hpp
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <nano/lib/constants.hpp>
 #include <nano/lib/locks.hpp>
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/numbers_templ.hpp>
@@ -22,6 +23,8 @@
 #include <thread>
 #include <unordered_set>
 
+using namespace std::chrono_literals;
+
 namespace mi = boost::multi_index;
 
 namespace nano
diff --git a/nano/node/scheduler/optimistic.hpp b/nano/node/scheduler/optimistic.hpp
@@ -1,6 +1,11 @@
 #pragma once
 
 #include <nano/lib/locks.hpp>
+
+#include <chrono>
+
+using namespace std::chrono_literals;
+
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/numbers_templ.hpp>
 #include <nano/lib/timer.hpp>
diff --git a/nano/node/transport/channel.cpp b/nano/node/transport/channel.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/node/endpoint.hpp>
 #include <nano/node/node.hpp>
 #include <nano/node/transport/channel.hpp>
diff --git a/nano/node/transport/fake.cpp b/nano/node/transport/fake.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/boost/asio/post.hpp>
 #include <nano/node/network.hpp>
 #include <nano/node/node.hpp>
diff --git a/nano/node/transport/inproc.cpp b/nano/node/transport/inproc.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/boost/asio/post.hpp>
 #include <nano/node/network.hpp>
 #include <nano/node/node.hpp>
diff --git a/nano/node/transport/loopback.cpp b/nano/node/transport/loopback.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/boost/asio/post.hpp>
 #include <nano/node/network.hpp>
 #include <nano/node/node.hpp>
diff --git a/nano/node/transport/message_deserializer.cpp b/nano/node/transport/message_deserializer.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/enum_util.hpp>
 #include <nano/node/node.hpp>
 #include <nano/node/transport/message_deserializer.hpp>
diff --git a/nano/node/transport/tcp_channel.cpp b/nano/node/transport/tcp_channel.cpp
@@ -1,3 +1,4 @@
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/stacktrace.hpp>
 #include <nano/lib/stats.hpp>
 #include <nano/lib/utility.hpp>
diff --git a/nano/node/vote_generator.hpp b/nano/node/vote_generator.hpp
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <nano/secure/network_params.hpp>
 #include <nano/lib/interval.hpp>
 #include <nano/lib/locks.hpp>
 #include <nano/lib/logging.hpp>
diff --git a/nano/secure/CMakeLists.txt b/nano/secure/CMakeLists.txt
@@ -10,6 +10,8 @@ add_library(
   endpoint_key.hpp
   endpoint_key.cpp
   fwd.hpp
+  network_params.hpp
+  network_params.cpp
   generate_cache_flags.hpp
   ledger.hpp
   ledger.cpp
diff --git a/nano/secure/common.cpp b/nano/secure/common.cpp
diff --git a/nano/secure/common.hpp b/nano/secure/common.hpp
diff --git a/nano/secure/ledger.cpp b/nano/secure/ledger.cpp
diff --git a/nano/secure/ledger.hpp b/nano/secure/ledger.hpp
diff --git a/nano/secure/ledger_processor.cpp b/nano/secure/ledger_processor.cpp
diff --git a/nano/secure/network_params.cpp b/nano/secure/network_params.cpp
diff --git a/nano/secure/network_params.hpp b/nano/secure/network_params.hpp
diff --git a/nano/store/ledger_store.cpp b/nano/store/ledger_store.cpp
diff --git a/nano/test_common/random.cpp b/nano/test_common/random.cpp
diff --git a/nano/test_common/system.hpp b/nano/test_common/system.hpp

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include <nano/secure/network_params.hpp>`
`1`	`2`	`#include <nano/lib/files.hpp>`
`2`	`3`	`#include <nano/lib/logging.hpp>`
`3`	`4`	`#include <nano/store/backend.hpp>`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include <nano/secure/network_params.hpp>`
`1`	`2`	`#include <nano/lib/block_uniquer.hpp>`
`2`	`3`	`#include <nano/lib/blockbuilders.hpp>`
`3`	`4`	`#include <nano/lib/blocks.hpp>`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include <nano/secure/network_params.hpp>`
`1`	`2`	`#include <nano/lib/block_type.hpp>`
`2`	`3`	`#include <nano/lib/blocks.hpp>`
`3`	`4`	`#include <nano/lib/config.hpp>`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include <nano/secure/network_params.hpp>`
`1`	`2`	`#include <nano/lib/epoch.hpp>`
`2`	`3`	`#include <nano/secure/common.hpp>`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include <nano/secure/network_params.hpp>`
`1`	`2`	`#include <nano/lib/block_sideband.hpp>`
`2`	`3`	`#include <nano/lib/block_type.hpp>`
`3`	`4`	`#include <nano/lib/blockbuilders.hpp>`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include <nano/secure/network_params.hpp>`
`1`	`2`	`#include <nano/crypto_lib/random_pool.hpp>`
`2`	`3`	`#include <nano/lib/blockbuilders.hpp>`
`3`	`4`	`#include <nano/lib/blocks.hpp>`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#include <nano/lib/blockbuilders.hpp>`
	`2`	`+#include <nano/secure/network_params.hpp>`
`2`	`3`	`#include <nano/lib/blocks.hpp>`
`3`	`4`	`#include <nano/lib/network_filter.hpp>`
`4`	`5`	`#include <nano/lib/stream.hpp>`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include <nano/secure/network_params.hpp>`
`1`	`2`	`#include <nano/lib/balance_formatting.hpp>`
`2`	`3`	`#include <nano/lib/numbers.hpp>`
`3`	`4`	`#include <nano/lib/numbers_templ.hpp>`