Merge pull request nanocurrency#5023 "Refactor wallet API to use nano::result (boost outcome) and direct return values"

Refactor wallet API to use nano::result (boost outcome) and direct return values

Author: pwojcikdev

nano/boost/outcome.hpp

@@ -1,5 +1,8 @@
 #pragma once
 
+// Disable [[nodiscard]] for outcome results
+#define BOOST_OUTCOME_NODISCARD
+
 #include <boost/outcome.hpp>
 
 namespace outcome = BOOST_OUTCOME_V2_NAMESPACE;

nano/core_test/node.cpp

@@ -1058,11 +1058,11 @@ TEST (node, fork_no_vote_quorum)
 	auto & node2 (*system.nodes[1]);
 	auto & node3 (*system.nodes[2]);
 	system.wallet (0)->insert_adhoc (nano::dev::genesis_key.prv);
-	auto key4 (system.wallet (0)->deterministic_insert ());
+	auto key4 = system.wallet (0)->deterministic_insert ().value ();
 	system.wallet (0)->send_action (nano::dev::genesis_key.pub, key4, nano::dev::constants.genesis_amount / 4);
-	auto key1 (system.wallet (1)->deterministic_insert ());
+	auto key1 = system.wallet (1)->deterministic_insert ().value ();
 	system.wallet (1)->set_representative (key1);
-	auto block (system.wallet (0)->send_action (nano::dev::genesis_key.pub, key1, node1.config.receive_minimum.number ()));
+	auto block = system.wallet (0)->send_action (nano::dev::genesis_key.pub, key1, node1.config.receive_minimum.number ());
 	ASSERT_NE (nullptr, block);
 	ASSERT_TIMELY (30s, node3.balance (key1) == node1.config.receive_minimum.number () && node2.balance (key1) == node1.config.receive_minimum.number () && node1.balance (key1) == node1.config.receive_minimum.number ());
 	ASSERT_EQ (node1.config.receive_minimum.number (), node1.weight (key1));
@@ -1082,17 +1082,17 @@ TEST (node, fork_no_vote_quorum)
 	nano::test::process (node1, { send1 });
 	nano::test::process (node2, { send1 });
 	nano::test::process (node3, { send1 });
-	auto key2 (system.wallet (2)->deterministic_insert ());
+	auto key2 = system.wallet (2)->deterministic_insert ().value ();
 	auto send2 = nano::send_block_builder ()
 				 .previous (block->hash ())
 				 .destination (key2)
 				 .balance ((nano::dev::constants.genesis_amount / 4) - (node1.config.receive_minimum.number () * 2))
 				 .sign (nano::dev::genesis_key.prv, nano::dev::genesis_key.pub)
 				 .work (*system.work.generate (block->hash ()))
 				 .build ();
-	nano::raw_key key3;
-	ASSERT_FALSE (system.wallet (1)->fetch_prv (key1, key3));
-	auto vote = std::make_shared<nano::vote> (key1, key3, 0, 0, std::vector<nano::block_hash>{ send2->hash () });
+	auto key3_result = system.wallet (1)->fetch_prv (key1);
+	ASSERT_TRUE (key3_result);
+	auto vote = std::make_shared<nano::vote> (key1, key3_result.value (), 0, 0, std::vector<nano::block_hash>{ send2->hash () });
 	nano::messages::confirm_ack confirm{ nano::dev::network_params.network, vote };
 	auto channel = node2.network.find_node_id (node3.node_id.pub);
 	ASSERT_NE (nullptr, channel);