fix(MarkersPlot): swap subsetting genes and comparisons to avoid "incorrect number of dimensions" error

Author: pwwang

R/markersplot.R

@@ -375,9 +375,7 @@ MarkersPlot <- function(
         } else {
             genes <- dplyr::filter(markers, !!rlang::parse_expr(select))$gene
         }
-        genes <- unique(genes)
-        # subset the object to only include the selected genes
-        object <- subset(object, features = genes)
+
         # subset the object to only include the comparison groups
         comp_groups <- unique(unlist(strsplit(unique(as.character(markers[[comparison_by_1]])), ":")))
         if (length(comp_groups) > 1) {
@@ -386,6 +384,9 @@ MarkersPlot <- function(
             object@meta.data[[comparison_by_2]] <- ifelse(object@meta.data[[comparison_by_2]] == comp_groups, comp_groups, "Other")
             object@meta.data[[comparison_by_2]] <- factor(object@meta.data[[comparison_by_2]], levels = c(comp_groups, "Other"))
         }
+        genes <- unique(genes)
+        # subset the object to only include the selected genes
+        object <- subset(object, features = genes)
 
         args <- list(
             object,