feat: enhance error handling in makecall and add async hook tests

Author: pwwang

simplug.py

@@ -140,23 +140,34 @@ def makecall(call: SimplugImplCall, async_hook: bool = False):
     Returns:
         The result of the call
     """
+    spec_prefix = "[async]" if async_hook else ""
+    err_msg = (
+        "Error while calling hook implementation, "
+        f"plugin={call.plugin}; spec={spec_prefix}{call.impl.__name__}"
+    )
+    if inspect.iscoroutinefunction(call.impl):
+
+        async def coro():
+            try:
+                return await call.impl(*call.args, **call.kwargs)
+            except Exception as exc:
+                raise ResultError(err_msg) from exc
+
+        return coro()
+
     try:
         out = call.impl(*call.args, **call.kwargs)
     except Exception as exc:
-        raise ResultError(
-            f"Error while calling {call.plugin}.{call.impl.__name__}(...)"
-        ) from exc
+        raise ResultError(err_msg) from exc
 
-    if not async_hook:
-        return out
+    if async_hook:
 
-    if inspect.iscoroutine(out):
-        return out
+        async def coro():
+            return out
 
-    async def coro():
-        return out
+        return coro()
 
-    return coro()
+    return out
 
 
 class SimplugWrapper:

tests/test_simplug.py

@@ -1264,22 +1264,40 @@ class Specs:
         def hook(arg):
             ...
 
+        @simplug.spec
+        async def ahook(arg):
+            ...
+
     class Plugin1:
         @simplug.impl
         def hook(arg):
             return 1
 
+        @simplug.impl
+        async def ahook(arg):
+            return 1 / 0
+
     class Plugin2:
         name = "SomePlugin"
 
         @simplug.impl
         def hook(arg):
             return 1 / 0
 
-    simplug.register(Plugin1, Plugin2)
-    with pytest.raises(ResultError, match=r"SomePlugin\.hook"):
+        @simplug.impl
+        def ahook(arg):
+            return 1
+
+    with pytest.warns(SyncImplOnAsyncSpecWarning):
+        simplug.register(Plugin1, Plugin2)
+
+    with pytest.raises(ResultError, match=r"plugin=SomePlugin; spec=hook"):
         simplug.hooks.hook(1)
 
+    with pytest.raises(ResultError, match=r"plugin=plugin1; spec=\[async\]ahook"):
+        asyncio.run(simplug.hooks.ahook(1))
+
+
 def test_async_impl_on_sync_spec():
     simplug = Simplug("test_async_impl_on_sync_spec")