Skip to content

Commit fdd64c0

Browse files
madanagopaltMichael Fiess
authored andcommitted
logging changes (#1528)
* logging changes * logging changes * Revert "logging changes" This reverts commit 434ca9a. * logging changes This reverts commit 72cd42d.
1 parent 5400662 commit fdd64c0

File tree

6 files changed

+11
-14
lines changed

6 files changed

+11
-14
lines changed

examples/pxScene2d/src/pxScene2d.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2850,7 +2850,7 @@ void pxScene2d::setMouseEntered(rtRef<pxObject> o)//pxObject* o)
28502850
**/
28512851
rtError pxScene2d::setFocus(rtObjectRef o)
28522852
{
2853-
rtLogInfo("pxScene2d::setFocus");
2853+
rtLogDebug("pxScene2d::setFocus");
28542854
rtObjectRef focusObj;
28552855
if (o)
28562856
{
@@ -3816,7 +3816,7 @@ rtError pxSceneContainer::api(rtValue& v) const
38163816

38173817
rtError pxSceneContainer::ready(rtObjectRef& o) const
38183818
{
3819-
rtLogInfo("pxSceneContainer::ready\n");
3819+
rtLogDebug("pxSceneContainer::ready\n");
38203820
if (mScriptView) {
38213821
rtLogInfo("mScriptView is set!\n");
38223822
return mScriptView->ready(o);
@@ -3947,7 +3947,6 @@ rtError createObject2(const char* t, rtObjectRef& o)
39473947
pxScriptView::pxScriptView(const char* url, const char* /*lang*/, pxIViewContainer* container)
39483948
: mWidth(-1), mHeight(-1), mViewContainer(container), mRefCount(0)
39493949
{
3950-
rtLogInfo(__FUNCTION__);
39513950
rtLogDebug("pxScriptView::pxScriptView()entering\n");
39523951
mUrl = url;
39533952
#ifndef RUNINMAIN // NOTE this ifndef ends after runScript decl, below
@@ -4082,7 +4081,7 @@ rtError pxScriptView::textureMemoryUsage(rtValue& v)
40824081

40834082
rtError pxScriptView::getScene(int numArgs, const rtValue* args, rtValue* result, void* ctx)
40844083
{
4085-
rtLogInfo(__FUNCTION__);
4084+
rtLogDebug(__FUNCTION__);
40864085
if (ctx)
40874086
{
40884087
pxScriptView* v = (pxScriptView*)ctx;

examples/pxScene2d/src/pxScene2d.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1091,7 +1091,6 @@ class pxScriptView: public pxIView
10911091
#endif
10921092
virtual ~pxScriptView()
10931093
{
1094-
rtLogInfo(__FUNCTION__);
10951094
rtLogDebug("~pxScriptView for mUrl=%s\n",mUrl.cString());
10961095
// Clear out these references since the script context
10971096
// can outlive this view

examples/pxScene2d/src/rcvrcore/utils/FileUtils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ function loadFileWithSparkPermissionsCheck( accessControl, http1, http2, fileUri
138138
var isAllowed = accessControl.allows(fileUri);
139139
if (true == isAllowed)
140140
{
141-
console.log("local file access allowed for current file !!!");
141+
log.message(3, "local file access allowed for current file !!!");
142142

143143
if( fileUri.substring(0,5) === 'file:' ) {
144144
fileUri = fileUri.substring(5);

src/rtFileCache.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,13 +262,12 @@ rtError rtFileCache::addToCache(const rtHttpCacheData& data)
262262
return RT_ERROR;
263263
setFileSizeAndTime(filename);
264264

265-
rtLogInfo("addToCache url(%s) filename(%s) size(%ld) Cache expiration(%s)", url.cString(), filename.cString(), (long) mFileSizeMap[filename], data.expirationDate().cString());
266265

267266
mCacheMutex.lock();
268267
mCurrentSize += mFileSizeMap[filename];
269268
int64_t size = cleanup();
270269
mCacheMutex.unlock();
271-
rtLogInfo("current size after insertion and cleanup (%ld)",(long) size);
270+
rtLogInfo("addToCache url(%s) filename(%s) size(%ld) Cache expiration(%s) total cache size (%ld)", url.cString(), filename.cString(), (long) mFileSizeMap[filename], data.expirationDate().cString(), (long) size);
272271
return RT_OK;
273272
}
274273

src/rtScriptV8/rtScriptNode.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ void rtNodeContext::createEnvironment()
526526

527527
void rtNodeContext::clonedEnvironment(rtNodeContextRef clone_me)
528528
{
529-
rtLogInfo(__FUNCTION__);
529+
rtLogDebug(__FUNCTION__);
530530
Locker locker(mIsolate);
531531
Isolate::Scope isolate_scope(mIsolate);
532532
HandleScope handle_scope(mIsolate);
@@ -615,7 +615,7 @@ void rtNodeContext::clonedEnvironment(rtNodeContextRef clone_me)
615615

616616
rtNodeContext::~rtNodeContext()
617617
{
618-
rtLogInfo(__FUNCTION__);
618+
rtLogDebug(__FUNCTION__);
619619
//Make sure node is not destroyed abnormally
620620
if (true == node_is_initialized)
621621
{
@@ -1360,4 +1360,4 @@ rtError createScriptNode(rtScriptRef& script)
13601360
return RT_OK;
13611361
}
13621362

1363-
#endif // RTSCRIPT_SUPPORT_NODE
1363+
#endif // RTSCRIPT_SUPPORT_NODE

src/rtScriptV8/rtScriptV8.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ using namespace v8;
307307
rtV8Context::rtV8Context(Isolate *isolate, Platform *platform, uv_loop_t *loop) :
308308
mIsolate(isolate), mPlatform(platform), mUvLoop(loop), mRefCount(0), mDirname(rtString())
309309
{
310-
rtLogInfo(__FUNCTION__);
310+
rtLogDebug(__FUNCTION__);
311311
Locker locker(mIsolate);
312312
Isolate::Scope isolate_scope(mIsolate);
313313
HandleScope handle_scope(mIsolate);
@@ -460,7 +460,7 @@ Local<Value> rtV8Context::loadV8Module(const rtString &name)
460460
rtLogWarn("module '%s' not found", name.cString());
461461
return Local<Value>();
462462
} else {
463-
rtLogInfo("module '%s' found at '%s'", name.cString(), path.cString());
463+
rtLogDebug("module '%s' found at '%s'", name.cString(), path.cString());
464464
}
465465

466466
rtString contents;
@@ -1440,4 +1440,4 @@ namespace rtScriptV8NodeUtils
14401440

14411441
} // namespace
14421442

1443-
#endif
1443+
#endif

0 commit comments

Comments
 (0)