ci: enforce ty checks

The rules demoted for the migration are back at their default level and the
allow-list names the actual dependencies, so an unresolved import from a new
package is reported rather than ignored.

Author: s3alfisc

.github/workflows/ci-tests.yaml

@@ -13,6 +13,28 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  lint:
+    name: "Lint and type check"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+
+      - uses: prefix-dev/setup-pixi@v0.10.0
+        with:
+          pixi-version: v0.62.2
+          cache: true
+          cache-write: ${{ github.event_name == 'push' && github.ref_name == 'master' }}
+          frozen: true
+          # py312 is not linted itself: it is the environment the `ty` hook
+          # resolves third-party types against. Installing it here rather than
+          # in a separate step keeps it inside setup-pixi's cache.
+          environments: lint py312
+
+      - name: Run lint hooks
+        run: pixi run -e lint lint
+        env:
+          SKIP: no-commit-to-branch
+
   test-python:
     name: "Tests Python (${{ matrix.environment }}, ${{ matrix.os }})"
     runs-on: ${{ matrix.os }}

pixi.lock

@@ -164,9 +164,25 @@ docstring-code-line-length = 88
 [tool.ty]
 
 [tool.ty.analysis]
-# Keep optional and external imports equivalent to mypy's ignore_missing_imports.
-# Narrowed to the actual dependency list once the findings are cleared.
-allowed-unresolved-imports = ["**"]
+# Permit unresolved imports from optional and external dependencies.
+allowed-unresolved-imports = [
+    "maketables.**",
+    "matplotlib.**",
+    "pandas.**",
+    "numpy.**",
+    "scipy.**",
+    "seaborn.**",
+    "numba.**",
+    "torch.**",
+    "rpy2.**",
+    "lets_plot.**",
+    "formulaic.**",
+    "wildboottest.**",
+    "tabulate.**",
+    "joblib.**",
+    "narwhals.**",
+    "tqdm.**",
+]
 
 [tool.ty.environment]
 # Check against the oldest supported interpreter, even though the `ty` hook
@@ -177,22 +193,8 @@ python-version = "3.10"
 include = ["pyfixest"]
 
 [tool.ty.terminal]
-error-on-warning = false
 output-format = "concise"
 
-[tool.ty.rules]
-# ty's default rules are stricter than the existing mypy baseline. Report the
-# current compatibility findings as warnings while they are migrated.
-call-non-callable = "warn"
-invalid-argument-type = "warn"
-invalid-assignment = "warn"
-invalid-return-type = "warn"
-no-matching-overload = "warn"
-not-iterable = "warn"
-not-subscriptable = "warn"
-unresolved-attribute = "warn"
-unsupported-operator = "warn"
-
 # --------------------------------------------------------------------------------------
 # pixi configuration
 # --------------------------------------------------------------------------------------