Skip to content

Commit 389b579

Browse files
committed
TST: Don't deepcopy PdfReader objects
This breaks if PdfReader contains any un-pickleable attributes (such as file pointers)
1 parent c943f5f commit 389b579

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

tests/test_page.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -154,25 +154,25 @@ def test_mediabox_expansion_after_rotation(
154154

155155

156156
def test_transformation_equivalence():
157-
pdf_path = RESOURCE_ROOT / "labeled-edges-center-image.pdf"
158-
reader_base = PdfReader(pdf_path)
159-
page_base = reader_base.pages[0]
157+
def get_pages():
158+
pdf_path = RESOURCE_ROOT / "labeled-edges-center-image.pdf"
159+
reader_base = PdfReader(pdf_path)
160+
page_base = reader_base.pages[0]
160161

161-
pdf_path = RESOURCE_ROOT / "box.pdf"
162-
reader_add = PdfReader(pdf_path)
163-
page_box = reader_add.pages[0]
162+
pdf_path = RESOURCE_ROOT / "box.pdf"
163+
reader_add = PdfReader(pdf_path)
164+
page_box = reader_add.pages[0]
165+
return page_box, page_base
164166

165167
op = Transformation().scale(2).rotate(45)
166168

167169
# Option 1: The new way
168-
page_box1 = deepcopy(page_box)
169-
page_base1 = deepcopy(page_base)
170+
page_box1, page_base1 = get_pages()
170171
page_box1.add_transformation(op, expand=True)
171172
page_base1.merge_page(page_box1, expand=False)
172173

173174
# Option 2: The old way
174-
page_box2 = deepcopy(page_box)
175-
page_base2 = deepcopy(page_base)
175+
page_box2, page_base2 = get_pages()
176176
page_base2.merge_transformed_page(page_box2, op, expand=False)
177177
page_box2.add_transformation(op)
178178
page_base2.merge_page(page_box2)

0 commit comments

Comments
 (0)