DEV: Modify use of ignore Ruff rule ARG005 (#3215)

ARG005: Unused lambda argument. If there is a single unused lambda argument, replacing it with an underscore does not trigger the rule.

Author: j-t-1

pypdf/_page_labels.py

@@ -144,7 +144,7 @@ def get_label_from_nums(dictionary_object: DictionaryObject, index: int) -> str:
             break
         i += 2
     m = {
-        None: lambda n: "",
+        None: lambda _: "",
         "/D": lambda n: str(n),
         "/R": number2uppercase_roman_numeral,
         "/r": number2lowercase_roman_numeral,

pypdf/_writer.py

@@ -1838,7 +1838,7 @@ def add_outline_item_destination(
             self,
             page_destination.inc_parent_counter_outline
             if is_open
-            else (lambda x, y: 0),
+            else (lambda x, y: 0),  # noqa: ARG005
         )
         if "/Count" not in page_destination:
             page_destination[NameObject("/Count")] = NumberObject(0)

pyproject.toml

@@ -133,7 +133,6 @@ ignore = [
     "ARG001",  # Unused function argument
     "ARG002",  # Unused method argument
     "ARG004",  # Unused static method argument
-    "ARG005",  # Unused lambda argument
     "B028",    # No explicit `stacklevel` keyword argument found
     "B904",    # Within an `except` clause, raise exceptions with
     "B905",    # `zip()` without an explicit `strict=` parameter

tests/scripts/test_make_release.py

@@ -42,7 +42,7 @@ def test_get_git_commits_since_tag():
     make_release = pytest.importorskip("make_release")
 
     with open(COMMITS__VERSION_4_0_1, mode="rb") as commits, mock.patch(
-        "urllib.request.urlopen", side_effect=lambda n: commits
+        "urllib.request.urlopen", side_effect=lambda _: commits
     ), mock.patch("subprocess.check_output", return_value=GIT_LOG__VERSION_4_0_1):
         commits = make_release.get_git_commits_since_tag("4.0.1")
     assert commits == [
@@ -88,7 +88,7 @@ def test_get_formatted_changes():
     make_release = pytest.importorskip("make_release")
 
     with open(COMMITS__VERSION_4_0_1, mode="rb") as commits, mock.patch(
-        "urllib.request.urlopen", side_effect=lambda n: commits
+        "urllib.request.urlopen", side_effect=lambda _: commits
     ), mock.patch("subprocess.check_output", return_value=GIT_LOG__VERSION_4_0_1):
         output, output_with_user = make_release.get_formatted_changes("4.0.1")
 

tests/test_text_extraction.py

@@ -22,7 +22,7 @@
 
 
 @pytest.mark.samples
-@pytest.mark.parametrize(("visitor_text"), [None, lambda a, b, c, d, e: None])
+@pytest.mark.parametrize(("visitor_text"), [None, lambda a, b, c, d, e: None])  # noqa: ARG005
 def test_multi_language(visitor_text):
     reader = PdfReader(RESOURCE_ROOT / "multilang.pdf")
     txt = reader.pages[0].extract_text(visitor_text=visitor_text)