redef error and write/form tests error fixed

Author: dev-KingMaster

pypdf/_page.py

@@ -739,12 +739,13 @@ def _get_inline_images(self) -> dict[str, ImageFile]:
             for k, v in ii["settings"].items():
                 if k in {"/Length", "/L"}:  # no length is expected
                     continue
+                value_for_init: Any
                 if isinstance(v, list):
-                    value_for_init: Any = ArrayObject(
+                    value_for_init = ArrayObject(
                         [self._translate_value_inline_image(k, x) for x in v]
                     )
                 else:
-                    value_for_init: Any = self._translate_value_inline_image(k, v)
+                    value_for_init = self._translate_value_inline_image(k, v)
                 mapped_k = NameObject(_INLINE_IMAGE_KEY_MAPPING[k])
                 if mapped_k not in init:
                     init[mapped_k] = value_for_init

pypdf/_writer.py

@@ -990,7 +990,7 @@ def update_page_form_field_values(
                 ).get_object()
 
             for field, value in fields.items():
-                rectangle = cast(RectangleObject, annotation[AA.Rect])
+                rectangle = cast(RectangleObject, annotation_obj[AA.Rect])
                 if not (
                     self._get_qualified_field_name(parent_annotation) == field
                     or parent_annotation.get("/T", None) == field
@@ -1002,14 +1002,13 @@ def update_page_form_field_values(
                 ):
                     del parent_annotation["/I"]
                 if flags:
-                    annotation[NameObject(FA.Ff)] = NumberObject(flags)
-                # Set the field value
+                    annotation_obj[NameObject(FA.Ff)] = NumberObject(flags)
                 if not (value is None and flatten):  # Only change values if given by user and not flattening.
                     if isinstance(value, list):
                         lst = ArrayObject(TextStringObject(v) for v in value)
                         parent_annotation[NameObject(FA.V)] = lst
                     elif isinstance(value, tuple):
-                        annotation[NameObject(FA.V)] = TextStringObject(
+                        annotation_obj[NameObject(FA.V)] = TextStringObject(
                             value[0],
                         )
                     else:
@@ -1020,42 +1019,47 @@ def update_page_form_field_values(
                     # We can find the associated appearance stream object
                     # within the annotation.
                     v = NameObject(value)
-                    ap = cast(DictionaryObject, annotation[NameObject(AA.AP)])
+                    ap = cast(DictionaryObject, annotation_obj[NameObject(AA.AP)])
                     normal_ap = cast(DictionaryObject, ap["/N"])
                     if v not in normal_ap:
                         v = NameObject("/Off")
                     appearance_stream_obj = normal_ap.get(v)
-                    # Other cases will be updated through the for loop
-                    annotation[NameObject(AA.AS)] = v
-                    annotation[NameObject(FA.V)] = v
+                    # other cases will be updated through the for loop
+                    annotation_obj[NameObject(AA.AS)] = v
+                    annotation_obj[NameObject(FA.V)] = v
+                    if flatten and appearance_stream_obj is not None:
+                        # We basically copy the entire appearance stream, which should be an XObject that
+                        # is already registered. No need to add font resources.
+                        rct = cast(RectangleObject, annotation_obj[AA.Rect])
+                        self._add_apstream_object(page, appearance_stream_obj, field, rct[0], rct[1])
                 elif (
                     parent_annotation.get(FA.FT) == "/Tx"
                     or parent_annotation.get(FA.FT) == "/Ch"
                 ):
                     # Textbox; we need to generate the appearance stream object
                     if isinstance(value, tuple):
                         appearance_stream_obj = TextStreamAppearance.from_text_annotation(
-                            acro_form, parent_annotation, annotation, value[1], value[2]
+                            acro_form, parent_annotation, annotation_obj, value[1], value[2]
                         )
                     else:
                         appearance_stream_obj = TextStreamAppearance.from_text_annotation(
-                            acro_form, parent_annotation, annotation
+                            acro_form, parent_annotation, annotation_obj
                         )
                     # Add the appearance stream object
-                    if AA.AP not in annotation:
-                        annotation[NameObject(AA.AP)] = DictionaryObject(
+                    if AA.AP not in annotation_obj:
+                        annotation_obj[NameObject(AA.AP)] = DictionaryObject(
                             {NameObject("/N"): self._add_object(appearance_stream_obj)}
                         )
-                    elif "/N" not in (ap:= cast(DictionaryObject, annotation[AA.AP])):
-                        cast(DictionaryObject, annotation[NameObject(AA.AP)])[
+                    elif "/N" not in (ap := cast(DictionaryObject, annotation_obj[AA.AP])):
+                        cast(DictionaryObject, annotation_obj[NameObject(AA.AP)])[
                             NameObject("/N")
                         ] = self._add_object(appearance_stream_obj)
                     else:  # [/AP][/N] exists
-                        n = annotation[AA.AP]["/N"].indirect_reference.idnum  # type: ignore
+                        n = annotation_obj[AA.AP]["/N"].indirect_reference.idnum  # type: ignore
                         self._objects[n - 1] = appearance_stream_obj
                         appearance_stream_obj.indirect_reference = IndirectObject(n, 0, self)
                 elif (
-                    annotation.get(FA.FT) == "/Sig"
+                    annotation_obj.get(FA.FT) == "/Sig"
                 ):  # deprecated  # not implemented yet
                     logger_warning("Signature forms not implemented yet", __name__)
                 if flatten and appearance_stream_obj is not None: